Catch IllegalArgumentException when resolving target definition

[ptziegler]

When the target editor is opened, PDE tries to delete the old target handle as part of "Bug 545681 - UI Freeze of >800s in TargetEditor when opening editor".

If the profile is not locked (due to whatever reasons), an IllegalArgumentException is thrown, blocking the resolution of this file.

[ptziegler]

See #2141

[laeubi]

Sounds reasonable to me

[github-actions]

Test Results

   771 files  ±0     771 suites  ±0   59m 41s ⏱️ + 2m 11s
 3 648 tests ±0   3 594 ✅ ±0   54 💤 ±0  0 ❌ ±0 
10 878 runs  ±0  10 715 ✅ ±0  163 💤 ±0  0 ❌ ±0 

Results for commit 7e5e593. ± Comparison against base commit 5d4bf0c.

♻️ This comment has been updated with latest results.

[eclipse-pde-bot]

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ui/org.eclipse.pde.ui/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From ee8ceab451378feccf6c6adced73098b7067dba6 Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <[email protected]>
Date: Mon, 1 Dec 2025 08:17:08 +0000
Subject: [PATCH] Version bump(s) for 4.39 stream


diff --git a/ui/org.eclipse.pde.ui/META-INF/MANIFEST.MF b/ui/org.eclipse.pde.ui/META-INF/MANIFEST.MF
index f8db32e0c6..87bb6898ee 100644
--- a/ui/org.eclipse.pde.ui/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde.ui/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %name
 Bundle-SymbolicName: org.eclipse.pde.ui; singleton:=true
-Bundle-Version: 3.16.300.qualifier
+Bundle-Version: 3.16.400.qualifier
 Bundle-Activator: org.eclipse.pde.internal.ui.PDEPlugin
 Bundle-Vendor: %provider-name
 Bundle-Localization: plugin
-- 
2.51.2

Further information are available in Common Build Issues - Missing version increments.

[vogella]

Looks good, only the commit message and PR description seem to have a typo.

@ptziegler I think the NOT is incorrect, I did not test but would assume that the exception is thrown if the profile is locked.

"If the profile is not locked (due to whatever reasons), an IllegalArgumentException is thrown..."

[merks]

It's dealing with this case:

[ptziegler]

Yes. The problem is that PDE forgot that it had already unlocked the profile in the past. So when trying to unlock this already unlocked profile, the exception occurs.

[vogella]

I suggest to merge this one

[merks]

It looks fine to me as well.

[ptziegler]

I'm not a committer. Whoever wants to merge this has to be someone other than me.