Skip to content

Inline o.e.jdt.launching.macosx #849

@HannesWell

Description

@HannesWell

Currently the handling of VMInstalls for Mac, which have a special layout, is separated into the org.eclipse.jdt.launching.macosx bundle.
But as encountered repeatedly, this separation can cause difficulties to assemble a proper runtime, e.g. for tests since only the org.eclipse.jdt feature includes it and nothing else requires it.
Looking at the code and dependencies I see nothing that would cause harm on other platforms than Mac and all (in-directed) calls to it are already guarded by an OS check. And since there are only a few classes I wonder:
Can the org.eclipse.jdt.launching.macosx bundle be in-lined into org.eclipse.jdt.launching?

And similarly could org.eclipse.jdt.launching.ui.macosx be inlined too? Maybe into org.eclipse.jdt.debug.ui?

Maybe @stephan-herrmann or @iloveeclipse can answer this?

If there's no compelling reason speaking against it, I can provide a PR to move the content.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions