Validation markers are cut off when exporting to SVG (vscode-integration) #1639
-
|
Hey there, I was testing https://github.com.mcas.ms/eclipse-glsp/glsp/issues/1588 on our end after upgrading to GLSP 2.6.0 and noticed that when exporting to SVG that the validation markers are cut off due to the bounding box of the SVG 
Is there a way we can increase this bounding box? I think our marker placement is slightly different from the default so it would probably make sense for us to adjust this on our end as well if possible. Cheers |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 1 reply
-
|
Hi @jmenzies12! If it is just about the overall graph size, you can adapt that in the GLSPSvgExporter directly. By default we take the SVG bounding box of the SVG directly or otherwise try to combine the bounds of all children. If it is about individual elements, the bounds are calculated by the hidden bounds updater which also just uses the SVG bounding box unless the element explicitly specifies an element with Best regards, |
Beta Was this translation helpful? Give feedback.
-
|
Thanks @martin-fleck-at, that got me there. I ended up overriding GLSPSvgExporter and getBounds in order to add a 20px boundary. I initially tried overriding getSvgExportStyle however I ended up having to adjust the x and y co-ordinates of the bounds that we get from the SVG bounding box. |
Beta Was this translation helpful? Give feedback.
Hi @jmenzies12!
If it is just about the overall graph size, you can adapt that in the GLSPSvgExporter directly. By default we take the SVG bounding box of the SVG directly or otherwise try to combine the bounds of all children.
If it is about individual elements, the bounds are calculated by the hidden bounds updater which also just uses the SVG bounding box unless the element explicitly specifies an element with
bboxElementattribute set to true, e.g., the circular node.Best regards,
Martin