Runnable Embedded GlassFish improvements (stop on error, print message at the end) #25745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
OndroMih
commented
Oct 22, 2025
OndroMih
commented
- stop automatically on error when executing commands
- print Welcome message at the beginning
- print message after shutdown, as the last message. Either OK message or error message.
dmatej
reviewed
Oct 22, 2025
nucleus/core/kernel/src/main/java/org/glassfish/runnablejar/UberMain.java
Outdated
Show resolved
Hide resolved
pzygielo
reviewed
Oct 22, 2025
nucleus/core/kernel/src/main/java/org/glassfish/runnablejar/UberMain.java
Outdated
Show resolved
Hide resolved
OndroMih
force-pushed
the
ondromih-runnable-embedded-improvements
branch
from
6cb3e42 to
15d0fe1
Compare
pzygielo
reviewed
Oct 24, 2025
nucleus/core/kernel/src/main/java/org/glassfish/runnablejar/InfoPrinter.java
Outdated
Show resolved
Hide resolved
dmatej
requested changes
Oct 31, 2025
There was a problem hiding this comment.
Shutdown hooks are there to do the cleanup. When they stop logging, all output properly closed, going against the stream is wrong. In extreme it can cause some damage.
If I remember well, the last message is already written by the shutdown hook, if it is not, we can fix it, but this is really a bad hack.
Handlers are also closeable (but don't implement Closeable), so they should not be used after the logging system was stopped.
I will take a look later ... embedded is bit different than Server, ie. shutdown hooks might not be executed as embedded was started inside existing JVM ... so perhaps something really has to be done, but not this way.
* stop automatically on error when executing commands * print Welcome message at the beginning * print message after shutdown, as the last message. Either OK message or error message.
Signed-off-by: David Matějček <[email protected]>
dmatej
force-pushed
the
ondromih-runnable-embedded-improvements
branch
from
a1597d1 to
9e48bb0
Compare
- Better handling of System.exit and the goodbye message - Processing errors to error codes (TODO: extend) - enums processed completely - Using System.console instead of STDIN for prompt - Minimalized shutdown hook - UberMain is now AutoCloseable, however main doesn't stop it - its purpose is to start it and return. - goodbye message can be null - anything can initiate exit for any reason. Signed-off-by: David Matějček <[email protected]>
…ents Revised UberMain
dmatej
approved these changes
Nov 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.