Skip to content

Commit 0058627

Browse files
committed
Switch from response.content to response.text
1 parent 9b2ae3c commit 0058627

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/webmention/resolution.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ def url_resolves(url):
1919
def fetch_and_validate_source(source, target):
2020
response = requests.get(source)
2121
if response.status_code == 200:
22-
if target in str(response.content):
23-
return response.content
22+
if target in response.text:
23+
return response.text
2424
else:
2525
raise TargetNotFoundError("Source URL did not contain target URL")
2626
else:

tests/test_resolution.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,10 @@ def test_url_resolves_when_does_not_resolve(mock_resolve):
2626
def test_fetch_and_validate_source_happy_path(mock_get, test_source, test_target):
2727
mock_response = Mock()
2828
mock_response.status_code = 200
29-
mock_response.content = '<a href="{href}">{href}</a>'.format(href=test_target)
29+
mock_response.text = '<a href="{href}">{href}</a>'.format(href=test_target)
3030
mock_get.return_value = mock_response
3131

32-
assert fetch_and_validate_source(test_source, test_target) == mock_response.content
32+
assert fetch_and_validate_source(test_source, test_target) == mock_response.text
3333

3434

3535
@patch("requests.get")
@@ -46,7 +46,7 @@ def test_fetch_and_validate_source_when_source_unavailable(mock_get, test_source
4646
def test_fetch_and_validate_source_when_source_does_not_contain_target(mock_get, test_source, test_target):
4747
mock_response = Mock()
4848
mock_response.status_code = 200
49-
mock_response.content = "foo"
49+
mock_response.text = "foo"
5050
mock_get.return_value = mock_response
5151

5252
with pytest.raises(TargetNotFoundError):

0 commit comments

Comments
 (0)