Enable additional buttons when defined

[DynaMight1124]

Hi

Sorry to add to the list :) I'm currently building a ESP32-P4 device and it has ABXY & L/R buttons. All defined in config.h. I notice that SNES works great with all buttons however the others dont take advantage of the additional buttons. I know the original Odroid only had the two action buttons but it would be nice to allow the additional buttons for systems like Megadrive (either 3 or 6 button) and also Doom to allow easier weapon switching, strafing etc. I havent fully explored GBA yet so not sure if the L/R buttons are mapped. Most of the other systems wont need any adjustment since they were only 2 button anyway!

Happy to discuss/give suggestions for potential button mapping if wanted, again, no rush, just putting it out there for when you have time :)

Thanks

[ducalex]

I agree support for extra button should "just work" when they're present.

You've given some examples but I think the first step would be to make an exhaustive list of all the apps we can improve and what additional mappings (or changes) you'd like to see.

Then we can choose what's the best way to make it happen!

[DynaMight1124]

Hi

Yes sounds like a good plan, I'll have a think about it over the next few days.

Shall we assume maybe 3 possible combinations (for action buttons) AB, ABXY and ABXYLR? then assuming whats been defined it can slot into one of the possible combinations?

Thanks

[DynaMight1124]

Hi

Got a little side tracked with things but had a think. I am not sure if we need to make many changes except for MD and Doom.

So for MD I got:
AB: Same as before
ABXY: Y = A, B = B & A = C (Gives you ABC across the buttons)
ABXYLR: Y = A, B = B & A = C, L = X, X = Y, R = Z (Same again, ABC across and then XYZ from left to right)
but should also have a 3/6 button toggle as theres a small selection of games that wont work at all with a 6 button controller but if 6 button isnt easy/possible when its not major problem, all games have a 3 button fallback as far as I'm aware, just nicer to play games like SF2 with all punch/kick buttons.

As for Doom, theres quite a few choices since theres lots of possible button combinations. Without playing with the button combos its hard to know how natural it would feel, then theres if we make sweeping changes when there are additional buttons or just add onto the existing while keeping originals as are.

I kinda settled on:
AB: Same as before
ABXY: A = key_fire, B = key_strafe, X = weapontoggle, Y = key_use
ABXYLR: A = key_fire, B = key_map, X = weapontoggle, Y = key_use, L = key_strafeleft, R = key_straferight
or:
ABXYLR: A = key_speed, B = key_map, X = weapontoggle, Y = key_use, L = key_strafe, R = key_fire

Is it easy as amending/adding buttons/keys in prboom-go/main/main.c then recompiling? Happy to have a play and see how they feel, if its more than that I had better leave it to the professional :)

[DynaMight1124]

So yeah it seems with Doom, I can just amend main.c.

Had a play with some configs and it does feel nicer with the additional buttons, esp with strafe being the L/R, before it was hard to strafe and shoot at the same time, kinda had to strafe, stop, shoot and strafe again.

I guess the question is, are we able to have some ifdefs or whatever to change the buttons if certain keys are defined? Even if this isnt possible/easy then just adding the additional buttons as per below would massively help and imo, probably enough.

{RG_KEY_UP, &key_up},
{RG_KEY_DOWN, &key_down},
{RG_KEY_LEFT, &key_left},
{RG_KEY_RIGHT, &key_right},
{RG_KEY_A, &key_fire},
{RG_KEY_A, &key_enter},
{RG_KEY_B, &key_speed},
{RG_KEY_B, &key_strafe},
{RG_KEY_B, &key_backspace},
{RG_KEY_MENU, &key_escape},
{RG_KEY_OPTION, &key_map},
{RG_KEY_START, &key_use},
{RG_KEY_SELECT, &key_weapontoggle},
{RG_KEY_X, &key_use},
{RG_KEY_Y, &key_weapontoggle},
{RG_KEY_L, &key_strafeleft},
{RG_KEY_R, &key_straferight},

I know use and weapontoggle are duplicated and potentially fairly easily accessible on some/most devices via start/select anyway but does feel a little nicer being on the main pad. Obv any buttons are not set in stone so happy with whatever.

Also had a play with MD, took me a moment to understand but think I got it. Couldnt see if a 6 button is supported or not but changed gwenesis/main/main.c to: uint32_t keymap[8] = {RG_KEY_UP, RG_KEY_DOWN, RG_KEY_LEFT, RG_KEY_RIGHT, RG_KEY_B, RG_KEY_A, RG_KEY_Y, RG_KEY_START};

Interestingly it seems like A & B get mixed up? I assume gwenesis_io.c has the mapping order? states:
7 6 5 4 3 2 1 0
Start A B C R L D U

So the button after Right should be C but I had to set the button to RG_KEY_B, which should be B. I ran the tests using the 240p test suite's built in controller test https://artemiourbina.itch.io/240p-test-suite

Anyway the above works with ABC on the MD being YBA on my ABXY pad. While I assume Doom would work perfectly as is for both devices with only A/B and also devices that have more buttons, the current changes I've done for MD wont since it unmaps the A button from Select.

Anyway, I'll stop rambling.