Remove file path trimming in tar compress #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulsh
changed the title
Collaborator
|
I'm not sure if it'd be best to have a @tboerger thoughts? |
Contributor
|
Instead of changing root paths I would prefer an integration of handling Drone volumes, than you can simply create voules for any part you want to cache. |
Collaborator
|
@tboerger can you explain more about that? I didn't think the plugins really had any access to what one sets as a volume. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using s3-cache plugin and I need to cache an absolute path (/var/lib/docker), so for doing that compression lib must accept and work with absolute paths. There is a line that trim the first "/", and that is the reason that the plugin can't work with absolute path.
The solution is avoid trim the path.