Skip to content

Stop using 2.x packages in InProcessNewShimWebsite testasset #64120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
+32 −38
Open

Stop using 2.x packages in InProcessNewShimWebsite testasset #64120

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
c42ea80
Fix CG alerts
wtgodbe Oct 20, 2025
d45b600
Just kestrel.core
wtgodbe Oct 20, 2025
f115f9d
Multitarget
wtgodbe Oct 20, 2025
05a26be
Fixup
wtgodbe Oct 20, 2025
26bdc25
Refs
wtgodbe Oct 20, 2025
b2a2ef1
FrameworkRef
wtgodbe Oct 20, 2025
1961b81
Xunit
wtgodbe Oct 20, 2025
b4048bd
Try this
wtgodbe Oct 21, 2025
1436865
Add back fref
wtgodbe Oct 21, 2025
357903a
Just newhsim
wtgodbe Oct 21, 2025
a654b70
Typo
wtgodbe Oct 21, 2025
f2b8c67
Fixup
wtgodbe Oct 21, 2025
a9e3c6a
Fix some errors
wtgodbe Oct 27, 2025
b5295b9
Suppress analyzer warnings in InProcessWebSite
halter73 Oct 27, 2025
59d1e2f
Fix TFM for publish
wtgodbe Oct 28, 2025
747a0a3
Only 1 TFM
wtgodbe Oct 30, 2025
548c503
Revert
wtgodbe Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions eng/Version.Details.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,10 +114,10 @@ This file should be imported by eng/Versions.props
<optimizationwindows_ntx64MIBCRuntimePackageVersion>1.0.0-prerelease.25502.1</optimizationwindows_ntx64MIBCRuntimePackageVersion>
<optimizationwindows_ntx86MIBCRuntimePackageVersion>1.0.0-prerelease.25502.1</optimizationwindows_ntx86MIBCRuntimePackageVersion>
<!-- dotnet/msbuild dependencies -->
<MicrosoftBuildPackageVersion>17.12.36</MicrosoftBuildPackageVersion>
<MicrosoftBuildFrameworkPackageVersion>17.12.36</MicrosoftBuildFrameworkPackageVersion>
<MicrosoftBuildTasksCorePackageVersion>17.12.36</MicrosoftBuildTasksCorePackageVersion>
<MicrosoftBuildUtilitiesCorePackageVersion>17.12.36</MicrosoftBuildUtilitiesCorePackageVersion>
<MicrosoftBuildPackageVersion>17.12.50</MicrosoftBuildPackageVersion>
<MicrosoftBuildFrameworkPackageVersion>17.12.50</MicrosoftBuildFrameworkPackageVersion>
<MicrosoftBuildTasksCorePackageVersion>17.12.50</MicrosoftBuildTasksCorePackageVersion>
<MicrosoftBuildUtilitiesCorePackageVersion>17.12.50</MicrosoftBuildUtilitiesCorePackageVersion>
</PropertyGroup>
<!--Property group for alternate package version names-->
<PropertyGroup>
Expand Down
16 changes: 8 additions & 8 deletions eng/Version.Details.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,21 +424,21 @@
</Dependency>
<!-- Dependencies required for source build to lift to the previously-source-built version. -->
<!-- These versions are manually updated -->
<Dependency Name="Microsoft.Build" Version="17.12.36" Label="Manual">
<Dependency Name="Microsoft.Build" Version="17.12.50" Label="Manual">
<Uri>https://github.com/dotnet/msbuild</Uri>
<Sha>d1cce8d7cc03c23a4f1bad8e9240714fd9d199a3</Sha>
<Sha>465c45808f0e9f3c32eb145101eeeccdc29d39e6</Sha>
</Dependency>
<Dependency Name="Microsoft.Build.Framework" Version="17.12.36" Label="Manual">
<Dependency Name="Microsoft.Build.Framework" Version="17.12.50" Label="Manual">
<Uri>https://github.com/dotnet/msbuild</Uri>
<Sha>d1cce8d7cc03c23a4f1bad8e9240714fd9d199a3</Sha>
<Sha>465c45808f0e9f3c32eb145101eeeccdc29d39e6</Sha>
</Dependency>
<Dependency Name="Microsoft.Build.Tasks.Core" Version="17.12.36" Label="Manual">
<Dependency Name="Microsoft.Build.Tasks.Core" Version="17.12.50" Label="Manual">
<Uri>https://github.com/dotnet/msbuild</Uri>
<Sha>d1cce8d7cc03c23a4f1bad8e9240714fd9d199a3</Sha>
<Sha>465c45808f0e9f3c32eb145101eeeccdc29d39e6</Sha>
</Dependency>
<Dependency Name="Microsoft.Build.Utilities.Core" Version="17.12.36" Label="Manual">
<Dependency Name="Microsoft.Build.Utilities.Core" Version="17.12.50" Label="Manual">
<Uri>https://github.com/dotnet/msbuild</Uri>
<Sha>d1cce8d7cc03c23a4f1bad8e9240714fd9d199a3</Sha>
<Sha>465c45808f0e9f3c32eb145101eeeccdc29d39e6</Sha>
</Dependency>
<Dependency Name="NuGet.Frameworks" Version="7.0.0-preview.1.1610" Label="Manual">
<Uri>https://github.com/dotnet/dotnet</Uri>
Expand Down
19 changes: 11 additions & 8 deletions src/Servers/IIS/IIS/test/testassets/InProcessNewShimWebSite/InProcessNewShimWebSite.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,28 +35,31 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.AspNetCore.Hosting" Version="2.2.0" >
<PackageReference Include="Microsoft.AspNetCore.Hosting" Version="2.3.0" >
<AllowExplicitReference>true</AllowExplicitReference>
</PackageReference>
<PackageReference Include="Microsoft.AspNetCore.ResponseCompression" Version="2.2.0" >
<PackageReference Include="Microsoft.AspNetCore.ResponseCompression" Version="2.3.0" >
<AllowExplicitReference>true</AllowExplicitReference>
</PackageReference>
<PackageReference Include="Microsoft.AspNetCore.Server.IISIntegration" Version="2.2.0" >
<PackageReference Include="Microsoft.AspNetCore.Server.IISIntegration" Version="2.3.0" >
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this won't work as I think InProcess support was added in 2.2.

This csproj exists to test ANCM compatibility with older TFMs. Is there a way to change it to target the oldest supported TFM that is not 2.3?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these packages were discontinued after 2.2, so I'm not sure - the only update we need to make is kestrel.core, so maybe I'll try just updating that one

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that doesn't work - would it be sufficient to multitarget DefaultNetCoreTargetFramework and CurrentLtsTargetFramework, and remove all the 2.x PackageRefs?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No because we want to target an older TFM to verify back-compat. Those are the same values currently

aspnetcore/eng/Versions.props

Lines 52 to 56 in d434929

<DefaultNetCoreTargetFramework>net10.0</DefaultNetCoreTargetFramework>
<!-- this should usually match for LTS builds, and be off-by-one otherwise;
example use-case here is OOB packages where Aspire wants to be able to consume
new features specific to OOB -->
<CurrentLtsTargetFramework>net10.0</CurrentLtsTargetFramework>

Ideally, it'd target net8.0 right now.

<AllowExplicitReference>true</AllowExplicitReference>
</PackageReference>
<PackageReference Include="Microsoft.AspNetCore.Server.Kestrel" Version="2.2.0" >
<PackageReference Include="Microsoft.AspNetCore.Server.Kestrel" Version="2.3.0" >
<AllowExplicitReference>true</AllowExplicitReference>
</PackageReference>
<PackageReference Include="Microsoft.AspNetCore.HttpsPolicy" Version="2.2.0" >
<PackageReference Include="Microsoft.AspNetCore.Server.Kestrel.Core" Version="2.3.6" >
<AllowExplicitReference>true</AllowExplicitReference>
</PackageReference>
<PackageReference Include="Microsoft.Extensions.Configuration.EnvironmentVariables" Version="2.2.0" >
<PackageReference Include="Microsoft.AspNetCore.HttpsPolicy" Version="2.3.0" >
<AllowExplicitReference>true</AllowExplicitReference>
</PackageReference>
<PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="2.2.0" >
<PackageReference Include="Microsoft.Extensions.Configuration.EnvironmentVariables" Version="8.0.0" >
<AllowExplicitReference>true</AllowExplicitReference>
</PackageReference>
<PackageReference Include="Microsoft.Extensions.Logging.Console" Version="2.2.0" >
<PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="8.0.1" >
<AllowExplicitReference>true</AllowExplicitReference>
</PackageReference>
<PackageReference Include="Microsoft.Extensions.Logging.Console" Version="8.0.1" >
<AllowExplicitReference>true</AllowExplicitReference>
</PackageReference>
<Reference Include="xunit.assert" />
Expand Down
Loading