Skip to content

Commit 18361c4

Browse files
authored
[Rollout] Production rollout 2026-05-05 (#6262)
#6261 ## Checklist - [ ] Verify this PR contains the expected changes - [ ] Follow the rollout process in issue #6261 - [ ] ⚠️ **DO NOT SQUASH** when merging - use merge commit
2 parents 99f3ff5 + 9470c44 commit 18361c4

36 files changed

Lines changed: 2035 additions & 121 deletions

File tree

‎.config/dotnet-tools.json‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,19 +3,19 @@
33
"isRoot": true,
44
"tools": {
55
"microsoft.dnceng.secretmanager": {
6-
"version": "1.1.0-beta.26216.2",
6+
"version": "1.1.0-beta.26230.1",
77
"commands": [
88
"secret-manager"
99
]
1010
},
1111
"dotnet-ef": {
12-
"version": "10.0.3",
12+
"version": "10.0.7",
1313
"commands": [
1414
"dotnet-ef"
1515
]
1616
},
1717
"microsoft.dnceng.configuration.bootstrap": {
18-
"version": "1.1.0-beta.26216.2",
18+
"version": "1.1.0-beta.26230.1",
1919
"commands": [
2020
"bootstrap-dnceng-configuration"
2121
]

‎.github/dependabot.yml‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,3 @@ updates:
99
directory: "/"
1010
schedule:
1111
interval: "weekly"
12-
groups:
13-
all-dependencies:
14-
patterns:
15-
- "*"

‎Directory.Packages.props‎

Lines changed: 24 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,11 @@
1010
<PackageVersion Include="Aspire.Hosting.Azure.Storage" Version="13.1.2" />
1111
<PackageVersion Include="Aspire.Hosting.Azure" Version="13.1.2" />
1212
<PackageVersion Include="Aspire.Hosting.Redis" Version="13.1.2" />
13-
<PackageVersion Include="Azure.Core" Version="1.51.1" />
13+
<PackageVersion Include="Azure.Core" Version="1.53.0" />
1414
<PackageVersion Include="Azure.Extensions.AspNetCore.Configuration.Secrets" Version="1.4.0" />
1515
<PackageVersion Include="Azure.Extensions.AspNetCore.DataProtection.Blobs" Version="1.5.1" />
1616
<PackageVersion Include="Azure.Extensions.AspNetCore.DataProtection.Keys" Version="1.6.1" />
17-
<PackageVersion Include="Azure.Identity" Version="1.17.1" />
17+
<PackageVersion Include="Azure.Identity" Version="1.21.0" />
1818
<PackageVersion Include="Azure.Monitor.OpenTelemetry.AspNetCore" Version="1.4.0" />
1919
<PackageVersion Include="Azure.Monitor.OpenTelemetry.Exporter" Version="1.6.0" />
2020
<PackageVersion Include="Azure.ResourceManager.AppContainers" Version="1.5.0" />
@@ -29,14 +29,15 @@
2929
<PackageVersion Include="Microsoft.AspNetCore.ApiPagination" Version="$(MicrosoftAspNetCoreApiPaginationVersion)" />
3030
<PackageVersion Include="Microsoft.AspNetCore.ApiVersioning.Swashbuckle" Version="$(MicrosoftAspNetCoreApiVersioningSwashbuckleVersion)" />
3131
<PackageVersion Include="Microsoft.AspNetCore.ApiVersioning" Version="$(MicrosoftAspNetCoreApiVersioningVersion)" />
32-
<PackageVersion Include="Microsoft.AspNetCore.Components.WebAssembly.DevServer" Version="10.0.3" />
33-
<PackageVersion Include="Microsoft.AspNetCore.Components.WebAssembly" Version="10.0.2" />
34-
<PackageVersion Include="Microsoft.AspNetCore.Identity.EntityFrameworkCore" Version="10.0.2" />
32+
<PackageVersion Include="Microsoft.AspNetCore.Components.WebAssembly.DevServer" Version="10.0.7" />
33+
<PackageVersion Include="Microsoft.AspNetCore.Components.WebAssembly" Version="10.0.7" />
34+
<PackageVersion Include="Microsoft.AspNetCore.Identity.EntityFrameworkCore" Version="10.0.7" />
3535
<PackageVersion Include="Microsoft.Azure.StackExchangeRedis" Version="3.3.1" />
36-
<PackageVersion Include="Microsoft.Build.Tasks.Core" Version="18.3.3" />
37-
<PackageVersion Include="Microsoft.Build.Utilities.Core" Version="18.3.3" />
36+
<PackageVersion Include="Microsoft.Build.Tasks.Core" Version="18.4.0" />
37+
<PackageVersion Include="Microsoft.Build.Utilities.Core" Version="18.4.0" />
3838
<PackageVersion Include="Microsoft.Build" Version="18.0.2" />
39-
<PackageVersion Include="Microsoft.Data.SqlClient" Version="6.1.4" />
39+
<PackageVersion Include="Microsoft.Data.SqlClient" Version="7.0.1" />
40+
<PackageVersion Include="Microsoft.Data.SqlClient.Extensions.Azure" Version="1.0.0" />
4041
<PackageVersion Include="Microsoft.DncEng.Configuration.Extensions" Version="$(MicrosoftDncEngConfigurationExtensionsVersion)" />
4142
<PackageVersion Include="Microsoft.DotNet.GitHub.Authentication" Version="$(MicrosoftDotNetGitHubAuthenticationVersion)" />
4243
<PackageVersion Include="Microsoft.DotNet.Internal.DependencyInjection.Testing" Version="$(MicrosoftDotNetInternalDependencyInjectionTestingVersion)" />
@@ -49,24 +50,24 @@
4950
<PackageVersion Include="Microsoft.DotNet.Services.Utility" Version="$(MicrosoftDotNetServicesUtilityVersion)" />
5051
<PackageVersion Include="Microsoft.DotNet.SwaggerGenerator.MSBuild" Version="$(MicrosoftDotNetSwaggerGeneratorMSBuildVersion)" />
5152
<PackageVersion Include="Microsoft.DotNet.VersionTools" Version="$(MicrosoftDotNetVersionToolsVersion)" />
52-
<PackageVersion Include="Microsoft.EntityFrameworkCore.Design" Version="10.0.2" />
53-
<PackageVersion Include="Microsoft.EntityFrameworkCore.InMemory" Version="10.0.2" />
53+
<PackageVersion Include="Microsoft.EntityFrameworkCore.Design" Version="10.0.7" />
54+
<PackageVersion Include="Microsoft.EntityFrameworkCore.InMemory" Version="10.0.7" />
5455
<PackageVersion Include="Microsoft.EntityFrameworkCore.SqlServer" Version="10.0.2" />
55-
<PackageVersion Include="Microsoft.EntityFrameworkCore" Version="10.0.2" />
56-
<PackageVersion Include="Microsoft.Extensions.Caching.Abstractions" Version="10.0.3" />
56+
<PackageVersion Include="Microsoft.EntityFrameworkCore" Version="10.0.7" />
57+
<PackageVersion Include="Microsoft.Extensions.Caching.Abstractions" Version="10.0.7" />
5758
<PackageVersion Include="Microsoft.Extensions.Configuration.UserSecrets" Version="10.0.2" />
58-
<PackageVersion Include="Microsoft.Extensions.Configuration" Version="10.0.3" />
59-
<PackageVersion Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="10.0.2" />
60-
<PackageVersion Include="Microsoft.Extensions.DependencyInjection" Version="10.0.2" />
61-
<PackageVersion Include="Microsoft.Extensions.FileSystemGlobbing" Version="10.0.3" />
59+
<PackageVersion Include="Microsoft.Extensions.Configuration" Version="10.0.7" />
60+
<PackageVersion Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="10.0.7" />
61+
<PackageVersion Include="Microsoft.Extensions.DependencyInjection" Version="10.0.7" />
62+
<PackageVersion Include="Microsoft.Extensions.FileSystemGlobbing" Version="10.0.7" />
6263
<PackageVersion Include="Microsoft.Extensions.Hosting" Version="10.0.2" />
63-
<PackageVersion Include="Microsoft.Extensions.Http.Resilience" Version="10.2.0" />
64-
<PackageVersion Include="Microsoft.Extensions.Http" Version="10.0.2" />
65-
<PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.2" />
64+
<PackageVersion Include="Microsoft.Extensions.Http.Resilience" Version="10.5.0" />
65+
<PackageVersion Include="Microsoft.Extensions.Http" Version="10.0.7" />
66+
<PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.7" />
6667
<PackageVersion Include="Microsoft.Extensions.Logging.ApplicationInsights" Version="2.23.0" />
6768
<PackageVersion Include="Microsoft.Extensions.Logging.Console" Version="10.0.2" />
68-
<PackageVersion Include="Microsoft.Extensions.Logging" Version="10.0.2" />
69-
<PackageVersion Include="Microsoft.Extensions.Options" Version="10.0.2" />
69+
<PackageVersion Include="Microsoft.Extensions.Logging" Version="10.0.7" />
70+
<PackageVersion Include="Microsoft.Extensions.Options" Version="10.0.7" />
7071
<PackageVersion Include="Microsoft.Extensions.ServiceDiscovery" Version="10.2.0" />
7172
<PackageVersion Include="Microsoft.FluentUI.AspNetCore.Components.Icons" Version="4.13.2" />
7273
<PackageVersion Include="Microsoft.FluentUI.AspNetCore.Components" Version="4.13.2" />
@@ -76,7 +77,8 @@
7677
<PackageVersion Include="Moq" Version="4.18.4" />
7778
<PackageVersion Include="Newtonsoft.Json" Version="13.0.4" />
7879
<PackageVersion Include="NRedisStack" Version="0.12.0" />
79-
<PackageVersion Include="NuGet.Packaging" Version="7.3.1" />
80+
<!-- Intentionally pinned for VMR bootstrap compatibility; only upgrade once bootstrap supports newer NuGet.Packaging versions. -->
81+
<PackageVersion Include="NuGet.Packaging" Version="7.0.3" />
8082
<PackageVersion Include="NUnit" Version="4.4.0" />
8183
<PackageVersion Include="NUnit3TestAdapter" Version="5.0.0" />
8284
<PackageVersion Include="Octokit" Version="14.0.0" />

‎docs/Darc.md‎

Lines changed: 59 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,7 @@ use darc to achieve them, as well as a general reference guide to darc commands.
1111
- [Updating dependencies in your local repository](#updating-dependencies-in-your-local-repository)
1212
- [Removing dependencies from a repository](#removing-dependencies-from-a-repository)
1313
- [Changing a dependency's type](#changing-a-dependencys-type)
14-
- ['Pinning' dependencies so they do not
15-
update](#pinning-dependencies-so-they-do-not-update)
14+
- ['Pinning' dependencies so they do not update](#pinning-dependencies-so-they-do-not-update)
1615
- [Coherent parent dependencies](#coherent-parent-dependencies)
1716
- [Version.Details.props and the SkipProperty attribute](#versiondetailsprops-and-the-skipproperty-attribute)
1817
- [Adding dependency flow](#adding-dependency-flow)
@@ -22,6 +21,7 @@ use darc to achieve them, as well as a general reference guide to darc commands.
2221
- [Assigning an individual build to a channel](#assigning-an-individual-build-to-a-channel)
2322
- [Locating the BAR build ID for a build](#locating-the-bar-build-id-for-a-build)
2423
- [Checking Merge Policies on Github](#checking-merge-policies-on-github)
24+
- [Making multiple configuration changes](#making-multiple-configuration-changes)
2525

2626
- [Command Reference](#command-reference)
2727
- [Parameters](#parameters)
@@ -1129,6 +1129,63 @@ You will find them on the `Checks` tab of each updates PRs created by maestro. D
11291129

11301130
![Checks Merge Policies](ChecksMergePolicies.png)
11311131

1132+
### Making multiple configuration changes
1133+
1134+
The configuration management commands support a common set of parameters that allow you to combine
1135+
multiple changes. By using `--configuration-branch` with `--no-pr`, you can stage several related
1136+
configuration changes onto the same branch and then open a single pull request for all of them.
1137+
1138+
You can either just keep supplying a constant value for `--configuration-branch` where the first call with create a pull request too and all subsequent calls with notice the branch and will pile onto the PR branch.
1139+
Alternatively, you can supply also `--no-pr` for the first calls if you want to stall the PR creation and only omit it on the last call to get the PR up when all changes are ready. This is somewhat faster as the tool does not need to query for the PR existence etc..
1140+
1141+
This is useful when you want to make a coordinated set of changes, such as:
1142+
1143+
- creating a new channel
1144+
- adding or updating subscriptions that flow into that channel
1145+
- updating merge policies for the affected repository and branch
1146+
1147+
#### How it works
1148+
1149+
1. Pick a branch name to hold your configuration changes.
1150+
2. Run each darc command with `--configuration-branch <branch-name>`.
1151+
3. Pass `--no-pr` on each command while you are still batching changes.
1152+
4. On the final command, omit `--no-pr` so darc opens one PR containing all of
1153+
the accumulated edits.
1154+
1155+
If the branch does not already exist, darc creates it from
1156+
`--configuration-base-branch` (or `production` if not specified).
1157+
1158+
#### Example
1159+
1160+
The following example creates a channel, adds a subscription, and updates
1161+
repository policies in a single PR:
1162+
1163+
```powershell
1164+
# Step 1: create or reuse a configuration branch and add the first change
1165+
darc add-channel `
1166+
--name "NET 11 Preview 4" `
1167+
--classification preview `
1168+
--configuration-branch net11-preview4-config `
1169+
--configuration-base-branch production `
1170+
--no-pr
1171+
1172+
# Step 2: add another change to the same configuration branch
1173+
darc add-subscription `
1174+
--channel "NET 11 Preview 4" `
1175+
--source-repo https://github.com/dotnet/source-repo `
1176+
--target-repo https://github.com/dotnet/target-repo `
1177+
--target-branch main `
1178+
--update-frequency everyBuild `
1179+
--configuration-branch net11-preview4-config `
1180+
--no-pr
1181+
1182+
# Step 3: make a final change and open a single PR for everything
1183+
darc set-repository-policies `
1184+
--repo https://github.com/dotnet/target-repo `
1185+
--branch main `
1186+
--all-checks-passed `
1187+
--configuration-branch net11-preview4-config
1188+
```
11321189

11331190
## Command Reference
11341191

‎eng/Version.Details.props‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,14 @@ This file should be imported by eng/Versions.props
66
<Project>
77
<PropertyGroup>
88
<!-- dotnet-arcade dependencies -->
9-
<MicrosoftDotNetArcadeSdkPackageVersion>10.0.0-beta.26208.4</MicrosoftDotNetArcadeSdkPackageVersion>
10-
<MicrosoftDotNetBuildTasksFeedPackageVersion>10.0.0-beta.26208.4</MicrosoftDotNetBuildTasksFeedPackageVersion>
11-
<MicrosoftDotNetSignToolPackageVersion>10.0.0-beta.26208.4</MicrosoftDotNetSignToolPackageVersion>
12-
<MicrosoftDotNetSwaggerGeneratorMSBuildPackageVersion>10.0.0-beta.26208.4</MicrosoftDotNetSwaggerGeneratorMSBuildPackageVersion>
9+
<MicrosoftDotNetArcadeSdkPackageVersion>10.0.0-beta.26222.2</MicrosoftDotNetArcadeSdkPackageVersion>
10+
<MicrosoftDotNetBuildTasksFeedPackageVersion>10.0.0-beta.26222.2</MicrosoftDotNetBuildTasksFeedPackageVersion>
11+
<MicrosoftDotNetSignToolPackageVersion>10.0.0-beta.26222.2</MicrosoftDotNetSignToolPackageVersion>
12+
<MicrosoftDotNetSwaggerGeneratorMSBuildPackageVersion>10.0.0-beta.26222.2</MicrosoftDotNetSwaggerGeneratorMSBuildPackageVersion>
1313
<MicrosoftDotNetVersionToolsPackageVersion>8.0.0-beta.25555.2</MicrosoftDotNetVersionToolsPackageVersion>
1414
<!-- dotnet-dnceng dependencies -->
15-
<MicrosoftDncEngConfigurationBootstrapPackageVersion>1.1.0-beta.26216.2</MicrosoftDncEngConfigurationBootstrapPackageVersion>
16-
<MicrosoftDncEngSecretManagerPackageVersion>1.1.0-beta.26216.2</MicrosoftDncEngSecretManagerPackageVersion>
15+
<MicrosoftDncEngConfigurationBootstrapPackageVersion>1.1.0-beta.26230.1</MicrosoftDncEngConfigurationBootstrapPackageVersion>
16+
<MicrosoftDncEngSecretManagerPackageVersion>1.1.0-beta.26230.1</MicrosoftDncEngSecretManagerPackageVersion>
1717
<!-- dotnet-dnceng-shared dependencies -->
1818
<MicrosoftAspNetCoreApiPaginationPackageVersion>1.1.0-beta.26214.1</MicrosoftAspNetCoreApiPaginationPackageVersion>
1919
<MicrosoftAspNetCoreApiVersioningPackageVersion>1.1.0-beta.26214.1</MicrosoftAspNetCoreApiVersioningPackageVersion>
@@ -29,7 +29,7 @@ This file should be imported by eng/Versions.props
2929
<MicrosoftDotNetKustoPackageVersion>1.1.0-beta.26214.1</MicrosoftDotNetKustoPackageVersion>
3030
<MicrosoftDotNetServicesUtilityPackageVersion>1.1.0-beta.26214.1</MicrosoftDotNetServicesUtilityPackageVersion>
3131
<!-- maestro-configuration dependencies -->
32-
<MicrosoftDotNetMaestroConfigurationClientPackageVersion>1.1.0-beta.26180.1</MicrosoftDotNetMaestroConfigurationClientPackageVersion>
32+
<MicrosoftDotNetMaestroConfigurationClientPackageVersion>1.1.0-beta.26224.1</MicrosoftDotNetMaestroConfigurationClientPackageVersion>
3333
</PropertyGroup>
3434
<!--Property group for alternate package version names-->
3535
<PropertyGroup>

‎eng/Version.Details.xml‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -55,37 +55,37 @@
5555
</Dependency>
5656
</ProductDependencies>
5757
<ToolsetDependencies>
58-
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="10.0.0-beta.26208.4">
58+
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="10.0.0-beta.26222.2">
5959
<Uri>https://github.com/dotnet/arcade</Uri>
60-
<Sha>ecdd5c6a7986cafabbf6a322ea09a07736a01a0d</Sha>
60+
<Sha>58713cb9a664ed67642127fcaf70b8c0c3b55ef2</Sha>
6161
</Dependency>
62-
<Dependency Name="Microsoft.DotNet.SignTool" Version="10.0.0-beta.26208.4">
62+
<Dependency Name="Microsoft.DotNet.SignTool" Version="10.0.0-beta.26222.2">
6363
<Uri>https://github.com/dotnet/arcade</Uri>
64-
<Sha>ecdd5c6a7986cafabbf6a322ea09a07736a01a0d</Sha>
64+
<Sha>58713cb9a664ed67642127fcaf70b8c0c3b55ef2</Sha>
6565
</Dependency>
66-
<Dependency Name="Microsoft.DotNet.Build.Tasks.Feed" Version="10.0.0-beta.26208.4">
66+
<Dependency Name="Microsoft.DotNet.Build.Tasks.Feed" Version="10.0.0-beta.26222.2">
6767
<Uri>https://github.com/dotnet/arcade</Uri>
68-
<Sha>ecdd5c6a7986cafabbf6a322ea09a07736a01a0d</Sha>
68+
<Sha>58713cb9a664ed67642127fcaf70b8c0c3b55ef2</Sha>
6969
</Dependency>
70-
<Dependency Name="Microsoft.DotNet.SwaggerGenerator.MSBuild" Version="10.0.0-beta.26208.4">
70+
<Dependency Name="Microsoft.DotNet.SwaggerGenerator.MSBuild" Version="10.0.0-beta.26222.2">
7171
<Uri>https://github.com/dotnet/arcade</Uri>
72-
<Sha>ecdd5c6a7986cafabbf6a322ea09a07736a01a0d</Sha>
72+
<Sha>58713cb9a664ed67642127fcaf70b8c0c3b55ef2</Sha>
7373
</Dependency>
7474
<Dependency Name="Microsoft.DotNet.VersionTools" Version="8.0.0-beta.25555.2">
7575
<Uri>https://github.com/dotnet/arcade</Uri>
7676
<Sha>048a8c0ba5b72234301a3605c424ee9f9ff99772</Sha>
7777
</Dependency>
78-
<Dependency Name="Microsoft.DncEng.SecretManager" Version="1.1.0-beta.26216.2">
78+
<Dependency Name="Microsoft.DncEng.SecretManager" Version="1.1.0-beta.26230.1">
7979
<Uri>https://github.com/dotnet/dnceng</Uri>
80-
<Sha>da634aee80eb1041dd86522bbfc408491a764cf6</Sha>
80+
<Sha>17d2dbe0d14f5f67be14b62f7b9d9684c2f6c2bc</Sha>
8181
</Dependency>
82-
<Dependency Name="Microsoft.DncEng.Configuration.Bootstrap" Version="1.1.0-beta.26216.2">
82+
<Dependency Name="Microsoft.DncEng.Configuration.Bootstrap" Version="1.1.0-beta.26230.1">
8383
<Uri>https://github.com/dotnet/dnceng</Uri>
84-
<Sha>da634aee80eb1041dd86522bbfc408491a764cf6</Sha>
84+
<Sha>17d2dbe0d14f5f67be14b62f7b9d9684c2f6c2bc</Sha>
8585
</Dependency>
86-
<Dependency Name="Microsoft.DotNet.MaestroConfiguration.Client" Version="1.1.0-beta.26180.1">
86+
<Dependency Name="Microsoft.DotNet.MaestroConfiguration.Client" Version="1.1.0-beta.26224.1">
8787
<Uri>https://dev.azure.com/dnceng/internal/_git/maestro-configuration</Uri>
88-
<Sha>55b3eccfde27561c1c37499f419e8c693c5eeb30</Sha>
88+
<Sha>82cfd34ff904edb0d5d0417713cc40655fe5e83b</Sha>
8989
</Dependency>
9090
</ToolsetDependencies>
9191
</Dependencies>

‎global.json‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,20 @@
11
{
22
"sdk": {
3-
"version": "10.0.202",
3+
"version": "10.0.203",
44
"rollForward": "minor"
55
},
66
"tools": {
7-
"dotnet": "10.0.202",
7+
"dotnet": "10.0.203",
88
"runtimes": {
99
"dotnet": [
10-
"10.0.6"
10+
"10.0.7"
1111
],
1212
"aspnetcore": [
13-
"10.0.6"
13+
"10.0.7"
1414
]
1515
}
1616
},
1717
"msbuild-sdks": {
18-
"Microsoft.DotNet.Arcade.Sdk": "10.0.0-beta.26208.4"
18+
"Microsoft.DotNet.Arcade.Sdk": "10.0.0-beta.26222.2"
1919
}
2020
}

‎src/Maestro/Maestro.Common/AppCredentials/AppCredential.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,8 @@ private static CachedInteractiveBrowserCredential GetInteractiveCredential(strin
8484
public static AppCredential CreateManagedIdentityCredential(string appId, string managedIdentityId)
8585
{
8686
var miCredential = managedIdentityId == "system"
87-
? new ManagedIdentityCredential()
88-
: new ManagedIdentityCredential(managedIdentityId);
87+
? new ManagedIdentityCredential(ManagedIdentityId.SystemAssigned)
88+
: new ManagedIdentityCredential(ManagedIdentityId.FromUserAssignedClientId(managedIdentityId));
8989

9090
var appCredential = new ClientAssertionCredential(
9191
TENANT_ID,

‎src/Maestro/Maestro.Common/AppCredentials/CredentialResolver.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ public static TokenCredential CreateCredential(CredentialResolverOptions options
2323
if (!string.IsNullOrEmpty(options.ManagedIdentityId))
2424
{
2525
return options.ManagedIdentityId == "system"
26-
? new ManagedIdentityCredential()
27-
: new ManagedIdentityCredential(options.ManagedIdentityId);
26+
? new ManagedIdentityCredential(ManagedIdentityId.SystemAssigned)
27+
: new ManagedIdentityCredential(ManagedIdentityId.FromUserAssignedClientId(options.ManagedIdentityId));
2828
}
2929

3030
// 3. Azure CLI authentication setup by the caller (for CI scenarios)

‎src/Maestro/Maestro.Common/AzureDevOpsTokens/AzureDevOpsTokenProvider.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,8 +122,8 @@ private static Dictionary<string, TokenCredential> GetCredentials(
122122
if (!string.IsNullOrEmpty(option.ManagedIdentityId))
123123
{
124124
credentials[account] = option.ManagedIdentityId == "system"
125-
? new ManagedIdentityCredential()
126-
: new ManagedIdentityCredential(option.ManagedIdentityId);
125+
? new ManagedIdentityCredential(ManagedIdentityId.SystemAssigned)
126+
: new ManagedIdentityCredential(ManagedIdentityId.FromUserAssignedClientId(option.ManagedIdentityId));
127127
continue;
128128
}
129129

0 commit comments

Comments
 (0)