Make multiarg work with env

[patricklodder]

While reviewing #10, I realized that one of the things that doesn't work with env-as-arg right now is multi-arg, i.e. -addnode=x -addnode=y.

We should add something for that.

[AbcSxyZ]

Which type of value this type of argument is requiring ? Obviously, we can't use an environment variable twice, so if we want to do something with it, I don't see another way than having a delimiter to separate values.

Or an amazing alternative : -e ADDNODE1=x -e ADDNODE2=y 🤣

[patricklodder]

$ grep -rn mapMultiArgs.count src/*cpp | sed 's/^.*mapMultiArgs.count..//;s/".*$//' |sort |uniq

• -addnode => <ipv4>:<port> or <ipv6>:<port> or <dnsname>:<port>
• -bind => <ipv4>:<port> or <ipv6>:<port>
• -bip9params <int>:<int>:<int>
• -connect => <ipv4>:<port> or <ipv6>:<port> or <dnsname>:<port>
• -debug => <alpha>
• -externalip => <ipv4>:<port> or <ipv6>:<port> or <dnsname>:<port>
• -loadblock => <filename> (NOTE: will be hard to use anyway)
• -onlynet => <alphanumeric>
• -rpcallowip => <ipv4>/<int> or <ipv6>/<int>
• -rpcauth => <string>:<string> (NOTE: this one may be tricky)
• -rpcbind => <ipv4>:<port> or <ipv6>:<port>
• -seednode => <ipv4>:<port> or <ipv6>:<port> or <dnsname>:<port>
• -uacomment => <string> (!!!)
• -whitebind => <ipv4>:<port> or <ipv6>:<port>
• -whitelist => <ipv4>/<int> or <ipv6>/<int>

I think ,

[xanimo]

While reviewing #10, I realized that one of the things that doesn't work with env-as-arg right now is multi-arg, i.e. -addnode=x -addnode=y.

We should add something for that.

i can confirm adding 2 nodes by running docker run -it <image> --addnode=x --addnode=y on an image built off main.

[patricklodder]

That's correct, but you don't want to do args like that when you k8s. That's what the -e ADDNODE=x is for...

[xanimo]

ah forgot about k8s. 👍

…

On Fri, Dec 3, 2021, 5:22 PM Patrick Lodder ***@***.***> wrote: That's correct, but you don't want to do args like that when you k8s. That's what the -e ADDNODE=x is for... — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#12 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHTBONE3UDX6EFGAPQQBQJDUPFUM5ANCNFSM5IFSEPNA> .