Move LazyGhost deprecation to ProxyFactory (#12101)

Author: derrabus

src/Configuration.php

@@ -652,17 +652,7 @@ public function setSchemaIgnoreClasses(array $schemaIgnoreClasses): void
 
     public function isNativeLazyObjectsEnabled(): bool
     {
-        $nativeLazyObjects = $this->attributes['nativeLazyObjects'] ?? false;
-
-        if (! $nativeLazyObjects && PHP_VERSION_ID >= 80400) {
-            Deprecation::trigger(
-                'doctrine/orm',
-                'https://github.com/doctrine/orm/pull/12005',
-                'Not enabling native lazy objects is deprecated and will be impossible in Doctrine ORM 4.0.',
-            );
-        }
-
-        return $nativeLazyObjects;
+        return $this->attributes['nativeLazyObjects'] ?? false;
     }
 
     public function enableNativeLazyObjects(bool $nativeLazyObjects): void

src/Proxy/ProxyFactory.php

@@ -152,7 +152,23 @@ public function __construct(
         string|null $proxyNs = null,
         bool|int $autoGenerate = self::AUTOGENERATE_NEVER,
     ) {
-        if (PHP_VERSION_ID >= 80400 && func_num_args() > 1) {
+        if (! $em->getConfiguration()->isNativeLazyObjectsEnabled()) {
+            if (PHP_VERSION_ID >= 80400) {
+                Deprecation::trigger(
+                    'doctrine/orm',
+                    'https://github.com/doctrine/orm/pull/12005',
+                    'Not enabling native lazy objects is deprecated and will be impossible in Doctrine ORM 4.0.',
+                );
+            }
+
+            if (! $proxyDir) {
+                throw ORMInvalidArgumentException::proxyDirectoryRequired();
+            }
+
+            if (! $proxyNs) {
+                throw ORMInvalidArgumentException::proxyNamespaceRequired();
+            }
+        } elseif (PHP_VERSION_ID >= 80400 && func_num_args() > 1) {
             Deprecation::trigger(
                 'doctrine/orm',
                 'https://github.com/doctrine/orm/pull/12005',
@@ -161,14 +177,6 @@ public function __construct(
             );
         }
 
-        if (! $proxyDir && ! $em->getConfiguration()->isNativeLazyObjectsEnabled()) {
-            throw ORMInvalidArgumentException::proxyDirectoryRequired();
-        }
-
-        if (! $proxyNs && ! $em->getConfiguration()->isNativeLazyObjectsEnabled()) {
-            throw ORMInvalidArgumentException::proxyNamespaceRequired();
-        }
-
         if (is_int($autoGenerate) ? $autoGenerate < 0 || $autoGenerate > 4 : ! is_bool($autoGenerate)) {
             throw ORMInvalidArgumentException::invalidAutoGenerateMode($autoGenerate);
         }

tests/Tests/ORM/ConfigurationTest.php

@@ -229,19 +229,4 @@ public function testDisablingNativeLazyObjectsIsDeprecated(): void
 
         $this->configuration->enableNativeLazyObjects(false);
     }
-
-    #[RequiresPhp('<8.4')]
-    public function testNotEnablingNativeLazyObjectIsFineOnPhpLowerThan84(): void
-    {
-        $this->expectNoDeprecationWithIdentifier('https://github.com/doctrine/orm/pull/12005');
-        self::assertFalse($this->configuration->isNativeLazyObjectsEnabled());
-    }
-
-    #[RequiresPhp('8.4')]
-    #[WithoutErrorHandler]
-    public function testNotEnablingNativeLazyObjectIsDeprecatedOnPhp84(): void
-    {
-        $this->expectDeprecationWithIdentifier('https://github.com/doctrine/orm/pull/12005');
-        self::assertFalse($this->configuration->isNativeLazyObjectsEnabled());
-    }
 }

tests/Tests/ORM/Proxy/ProxyFactoryTest.php

@@ -7,6 +7,7 @@
 use Doctrine\Common\EventManager;
 use Doctrine\DBAL\Connection;
 use Doctrine\DBAL\Platforms\AbstractPlatform;
+use Doctrine\Deprecations\PHPUnit\VerifyDeprecations;
 use Doctrine\ORM\EntityNotFoundException;
 use Doctrine\ORM\Mapping\ClassMetadata;
 use Doctrine\ORM\Persisters\Entity\BasicEntityPersister;
@@ -21,6 +22,7 @@
 use Doctrine\Tests\OrmTestCase;
 use PHPUnit\Framework\Attributes\Group;
 use PHPUnit\Framework\Attributes\RequiresPhp;
+use PHPUnit\Framework\Attributes\WithoutErrorHandler;
 use ReflectionClass;
 use ReflectionProperty;
 use stdClass;
@@ -34,10 +36,10 @@
  */
 class ProxyFactoryTest extends OrmTestCase
 {
-    private UnitOfWorkMock $uowMock;
+    use VerifyDeprecations;
 
+    private UnitOfWorkMock $uowMock;
     private EntityManagerMock $emMock;
-
     private ProxyFactory $proxyFactory;
 
     protected function setUp(): void
@@ -243,6 +245,37 @@ public function testProxyFactoryAcceptsNullProxyArgsWhenNativeLazyObjectsAreEnab
 
         self::assertTrue($reflection->isUninitializedLazyObject($proxy));
     }
+
+    #[RequiresPhp('8.4')]
+    #[WithoutErrorHandler]
+    public function testProxyFactoryTriggersDeprecationWhenNativeLazyObjectsAreDisabled(): void
+    {
+        $this->emMock->getConfiguration()->enableNativeLazyObjects(false);
+
+        $this->expectDeprecationWithIdentifier('https://github.com/doctrine/orm/pull/12005');
+
+        $this->proxyFactory = new ProxyFactory(
+            $this->emMock,
+            sys_get_temp_dir(),
+            'Proxies',
+            ProxyFactory::AUTOGENERATE_ALWAYS,
+        );
+    }
+
+    #[RequiresPhp('< 8.4')]
+    public function testProxyFactoryDoesNotTriggerDeprecationWhenNativeLazyObjectsAreDisabled(): void
+    {
+        $this->emMock->getConfiguration()->enableNativeLazyObjects(false);
+
+        $this->expectNoDeprecationWithIdentifier('https://github.com/doctrine/orm/pull/12005');
+
+        $this->proxyFactory = new ProxyFactory(
+            $this->emMock,
+            sys_get_temp_dir(),
+            'Proxies',
+            ProxyFactory::AUTOGENERATE_ALWAYS,
+        );
+    }
 }
 
 abstract class AbstractClass