Skip to content

Only filter out duplicates if they are of the same kind #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bangbangsheshotmedown wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Only filter out duplicates if they are of the same kind #781

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
93fcbc8
Only filter out duplicates if they are of the same kind
bangbangsheshotmedown Nov 10, 2024
88f04e5
Also compare full definition if matches
bangbangsheshotmedown Nov 10, 2024
5b95f71
Update doc
bangbangsheshotmedown Nov 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion src/dcd/server/autocomplete/complete.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,7 +592,16 @@ void setCompletions(T)(ref AutocompleteResponse response,
{
if (sym.name !is null && sym.name.length > 0 && isPublicCompletionKind(sym.kind)
&& (p is null ? true : toUpper(sym.name.data).startsWith(toUpper(p)))
&& !r.completions.canFind!(a => a.identifier == sym.name)
&& !r.completions.canFind!((a) {
// this filters out similar symbols
// fast check first, only compare full definition if it matches
bool same = a.identifier == sym.name && a.kind == sym.kind;
if (same) {
auto info = makeSymbolCompletionInfo(sym, sym.kind);
if (info.definition != a.definition) same = false;
}
return same;
})
&& sym.name[0] != '*'
&& mightBeRelevantInCompletionScope(sym, completionScope))
{
Expand All @@ -610,6 +619,16 @@ void setCompletions(T)(ref AutocompleteResponse response,
auto currentSymbols = completionScope.getSymbolsInCursorScope(cursorPosition);
foreach (s; currentSymbols.filter!(a => isPublicCompletionKind(a.kind)
&& toUpper(a.name.data).startsWith(toUpper(partial))
&& !response.completions.canFind!((r) {
// this filters out similar symbols
// fast check first, only compare full definition if it matches
bool same = (r.identifier == a.name && r.kind == a.kind);
if (same) {
auto info = makeSymbolCompletionInfo(a, a.kind);
if (info.definition != r.definition) same = false;
}
return same;
})
&& mightBeRelevantInCompletionScope(a, completionScope)))
{
response.completions ~= makeSymbolCompletionInfo(s, s.kind);
Expand Down
Loading