Skip to content

Allow editing transition labels by double-clicking#60

Open
cobalt-arc-dev wants to merge 1 commit into
dionyziz:masterfrom
cobalt-arc-dev:edit-transition-labels
Open

Allow editing transition labels by double-clicking#60
cobalt-arc-dev wants to merge 1 commit into
dionyziz:masterfrom
cobalt-arc-dev:edit-transition-labels

Conversation

@cobalt-arc-dev

Copy link
Copy Markdown

Fixes #39.

Summary:

  • Add hit testing for rendered transition label text, not just transition arrowheads.
  • Return the existing transition edit target when a label is double-clicked, so the current label input flow opens unchanged.
  • Match the rendered label position for straight, arced, detached, and self transitions.

Validation:

  • node --check site/js/render.js
  • find site/js -name '*.js' -print0 | xargs -0 -n1 node --check
  • git diff --check
  • Node VM harness covering normal transition label hit testing, self-transition label hit testing, and state hit testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Double clicking on an edge's label should edit it

1 participant