Explain submodules in README and bring back normalization #218
+52
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mielvds
force-pushed
the
adjust-submodules
branch
from
aaa740d to
373a904
Compare
Merged
davidlehn
approved these changes
Dec 5, 2025
Member
davidlehn
left a comment
davidlehn
left a comment
There was a problem hiding this comment.
Approving to move things forward. Thanks for the docs.
The "sibling" terminology needs to change. I used that because those dirs were actually siblings to the pyld dir. And that made sense with the setup I have of a top level "json-ld" dir with specs, implementations, and other files in one place. Pointing to a sub-sub-dir is something else.
Member
|
One comment is that the current text is word wrapped at ~80 chars as appropriate. Can be fixed later. |
Collaborator
Author
|
I've changed the sibling terminology to something more appropriate and applied word wrapping at 80. Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR