Replies: 3 comments 1 reply
|
The code was implemented in two passes: First to swap in HTTPX instead of requests. This was more "invasive", because it touched a lot of code. My thinking was: let's make sure this is stable before taking the next step. Second step was to implement an optional caching layer, with caching rules. I'd like to clean this code up a bit and do a little more testing... the httpclient and httpclient_cache is a bit too convoluted right now. My next steps/plan was:
Two questions about caching are:
I should be able to finish the cleanup shortly, I already started it locally. |
|
What about explicitly adding the libraries to the project dependencies? Is it ok to add the following to pyproject.toml |
|
To conclude this: Merged in 4.6.0. Caching implementation is here: https://github.com/dgunning/edgartools/blob/main/edgar/httpclient_cache.py |
Uh oh!
There was an error while loading. Please reload this page.
@paultiq What is the rollout plan for the request caching? Are we ready to explicitly add the dependencies to the library? Turn the feature on?
All reactions