Skip to content

access token query modifications #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

access token query modifications #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8084d31
added query parameters to access_token query
ToniIltanen Nov 10, 2017
9acec8d
Removed unneeded values from token query
ToniIltanen Nov 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/models/oic_session.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,9 +181,9 @@ def access_token_query
query = {
'grant_type' => 'authorization_code',
'code' => code,
'scope' => 'openid profile email user_name',
Copy link
Contributor

@triplem triplem Nov 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On https://nat.sakimura.org/2012/01/26/scopes-and-claims-in-openid-connect/ the following can be found:

profile – OPTIONAL. This requests that access to the End-User’s profile Claims excluding the address and email Claims at the UserInfo Endpoint be granted by the issued Access Token.
email – OPTIONAL. This requests that access to the email and verified Claims at the UserInfo Endpoint be granted by the issued Access Token.

I guess, removing all of the above in the scope does not really makes sense, does it?

'id_token' => id_token,
'redirect_uri' => "#{host_name}/oic/local_login",
'client_id' => client_config['client_id'],
'client_secret' => client_config['client_secret'],
}
end

Expand Down