Compact device-tree source creates illegal .dts syntax

[gsmecher]

The following device-tree source:

/dts-v1/;

/ {
    compact_label: compact_thing@0 { compatible = "baz"; };
};

causes lopper to generate illegal .dts when invoked as follows:

lopper --enhanced -f -i lopper/lops/lop-load.dts in.dts out.dts

Lopper bails with the following error message:

[ERROR]: unable to (force) compile ['/usr/bin/dtc', '-i', '.', '-o', '/tmp/tmpbld8b1e7/in.dts.dtb', '-I', 'dts', '-O', 'dtb', '/tmp/tmpbld8b1e7/in.dts.pp.enhanced', '-f']

         Error: in.dts:5.1-34 Properties must precede subnodes
         FATAL ERROR: Unable to parse input tree

The in.dts.pp.enhanced file contains:

/ {
    compact_label: compact_thing@0 { compatible = "baz"; };
lopper-label-1 = "compact_label";
};

The "lopper-label-1" label, here, is placed after the child node and not inside it. If I modify the device-tree source with an extra newline:

/dts-v1/;

/ {
    compact_label: compact_thing@0 {
	    compatible = "baz"; };
};

...everything is fine.

[gsmecher]

Similarly, when given the following:

/dts-v1/;
/ {
    sparse_label: compact_thing@1
    {
	    compatible = "baz";
    };
};

Lopper (--enhanced) produces and then bails on the following:

/ {
    sparse_label: compact_thing@1
lopper-label-2 = "sparse_label";
    {
     compatible = "baz";
    };
};

[gsmecher]

@zeddii, any comments? I'm not sure if this is your issue/PR to review, but I think you're the primary Lopper dev.

(I should know better than to submit a bug report just before a long weekend.)

thanks,
Graeme

[zeddii]

I commented on the commits directly, github may not have done the notification.

[gsmecher]

Hm - @zeddii, I still don't see anything in either the PR or the individual commits. If you've started a code review (rather than submitting individual comments), I think you have to "close off" your review session before I'll be able to see any of it.