Repository navigation
Commit d220bfd
committed
fix: give starting a terminal sign-in a rate limit bucket of its own
Starting a sign-in shared the devices limiter, which picks polling's 300 a minute per address whenever the body has a device code, before the request is checked. The sign-in request doesn't reject that extra field, so adding one moved it to the larger bucket, and rotating keys got around the 5 per key: one address could start up to 300 sign-ins a minute instead of 60. It now has its own limiter, with the same 60 a minute per address whatever the body says.1 parent 054f071 commit d220bfd
4 files changed
Lines changed: 30 additions & 1 deletion
File tree
- app/Providers
- routes
- tests
- Feature/Controllers/Api
- Unit/Providers
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
205 | 205 | | |
206 | 206 | | |
207 | 207 | | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
208 | 212 | | |
209 | 213 | | |
210 | 214 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
156 | 156 | | |
157 | 157 | | |
158 | 158 | | |
159 | | - | |
| 159 | + | |
160 | 160 | | |
161 | 161 | | |
162 | 162 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
117 | 117 | | |
118 | 118 | | |
119 | 119 | | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
115 | 115 | | |
116 | 116 | | |
117 | 117 | | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
118 | 133 | | |
119 | 134 | | |
120 | 135 | | |
| |||
0 commit comments