Skip to content

Commit 475efb1

Browse files
stereotype441Commit Queue
authored andcommitted
Revert "[dart2wasm] Also use --traps-never-happen in deferred loading mode"
This reverts commit 6bcbc74. Reason for revert: Broke pkg/dart2wasm/test/ir_test Original change's description: > [dart2wasm] Also use --traps-never-happen in deferred loading mode > > The dar2wasm compiler - when used in -O2 sound mode - should guarantee > that no wasm traps happen. So we should be able to use > `--traps-never-happen` in deferred loading mode just like in normal > mode. > > This saves around 1.2% in ACX Gallery > > Change-Id: I3d214b636b0bc2e8b18c2ef8c4bf0c86b19c23c8 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/458720 > Commit-Queue: Martin Kustermann <[email protected]> > Reviewed-by: Nate Biggs <[email protected]> Change-Id: If51986574a7dc587b64b258278d763d51b3d28df Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/458900 Commit-Queue: Paul Berry <[email protected]> Reviewed-by: Nicholas Shahan <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Auto-Submit: Paul Berry <[email protected]>
1 parent ec6a01c commit 475efb1

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

pkg/dartdev/lib/src/commands/compile.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -765,7 +765,6 @@ class CompileWasmCommand extends CompileSubcommandCommand {
765765
766766
--no-inline=*<noInline>*
767767
768-
--traps-never-happen
769768
-Os
770769
'''); // end of binaryenFlagsDeferredLoading
771770

0 commit comments

Comments
 (0)