Skip to content

Commit c5a565a

Browse files
committed
added TODO about bumping the Visual Studio warning level
disabled C4267 Visual Studio warnings for now
1 parent e5b3174 commit c5a565a

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

CMakeLists.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,10 @@ if (CMAKE_CXX_COMPILER_ID MATCHES "GNU")
4040
add_compile_options_safe(-Wuseless-cast)
4141
elseif (CMAKE_CXX_COMPILER_ID MATCHES "MSVC")
4242
add_compile_definitions(_CRT_SECURE_NO_WARNINGS)
43+
# TODO: bump warning level
44+
#add_compile_options(/W4) # Warning Level
45+
# TODO: enable warning
46+
add_compile_options(/wd4267) # warning C4267: '...': conversion from 'size_t' to 'unsigned int', possible loss of data
4347
elseif (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
4448
add_compile_options(-Weverything)
4549
# no need for c++98 compatibility

0 commit comments

Comments
 (0)