remove assert is_open

Author: samopolacek

gui/checkthread.cpp

@@ -79,7 +79,6 @@ static bool executeCommand(std::string exe, std::vector<std::string> args, std::
         std::ofstream fout();
         fout.exceptions(std::ios_base::failbit | std::ios_base::badbit);
         fout.open(redirect.substr(3));
-        assert(fout.is_open()); // If we ever disable exceptions, catch issues ASAP
         fout << process.readAllStandardError().toStdString();
     }
     return process.exitCode() == 0;

lib/analyzerinfo.cpp

@@ -67,7 +67,6 @@ void AnalyzerInformation::writeFilesTxt(const std::string &buildDir, const std::
     std::ofstream fout;
     fout.exceptions(std::ios_base::failbit | std::ios_base::badbit);
     fout.open(filesTxt);
-    assert(fout.is_open()); // If we ever disable exceptions, catch issues ASAP
 
     for (const std::string &f : sourcefiles) {
         const std::string afile = getFilename(f);
@@ -157,7 +156,6 @@ bool AnalyzerInformation::analyzeFile(const std::string &buildDir, const std::st
         return false;
 
     mOutputStream.open(mAnalyzerInfoFile);
-    assert(mOutputStream.is_open()); // If we ever disable exceptions on mOutputStream, catch issues ASAP
 
     mOutputStream << "<?xml version=\"1.0\"?>\n";
     mOutputStream << "<analyzerinfo hash=\"" << hash << "\">\n";

lib/cppcheck.cpp

@@ -276,7 +276,6 @@ static void createDumpFile(const Settings& settings,
     dumpFile = getDumpFileName(settings, filename);
 
     fdump.open(dumpFile);
-    assert(fdump.is_open()); // If we ever disable exceptions, catch issues ASAP
 
     // TODO: Technically, exceptions are allowed on the file so this is always false,
     // TODO: but the function is not aware of that as this function is not the owner of the file
@@ -287,7 +286,6 @@ static void createDumpFile(const Settings& settings,
         std::ofstream fout;
         fout.exceptions(std::ios_base::failbit | std::ios_base::badbit);
         fout.open(getCtuInfoFileName(dumpFile));
-        assert(fout.is_open()); // If we ever disable exceptions, catch issues ASAP
     }
 
     std::string language;
@@ -526,7 +524,6 @@ unsigned int CppCheck::check(const std::string &path)
             std::ofstream fout;
             fout.exceptions(std::ios_base::failbit | std::ios_base::badbit);
             fout.open(clangcmd);
-            assert(fout.is_open()); // If we ever disable exceptions, catch issues ASAP
             fout << exe << " " << args2 << " " << redirect2 << std::endl;
         } else if (mSettings.verbose && !mSettings.quiet) {
             mErrorLogger.reportOut(exe + " " + args2);
@@ -560,7 +557,6 @@ unsigned int CppCheck::check(const std::string &path)
             std::ofstream fout;
             fout.exceptions(std::ios_base::failbit | std::ios_base::badbit);
             fout.open(clangAst);
-            assert(fout.is_open()); // If we ever disable exceptions, catch issues ASAP
             fout << output2 << std::endl;
         }
 
@@ -746,7 +742,6 @@ unsigned int CppCheck::checkFile(const std::string& filename, const std::string
             const std::size_t fileNameHash = std::hash<std::string> {}(filename);
             filename2 = mSettings.plistOutput + filename2.substr(0, filename2.find('.')) + "_" + std::to_string(fileNameHash) + ".plist";
             mPlistFile.open(filename2);
-            assert(mPlistFile.is_open()); // If we ever disable exceptions, catch issues ASAP
 
             mPlistFile << ErrorLogger::plistHeader(version(), files);
         }
@@ -1455,7 +1450,6 @@ void CppCheck::executeAddons(const std::vector<std::string>& files)
         std::ofstream fout;
         fout.exceptions(std::ios_base::failbit | std::ios_base::badbit);
         fout.open(fileList);
-        assert(fout.is_open()); // If we ever disable exceptions, catch issues ASAP
 
         for (const std::string& f: files)
             fout << f << std::endl;
@@ -1719,7 +1713,6 @@ void CppCheck::analyseClangTidy(const ImportProject::FileSettings &fileSettings)
         std::ofstream fcmd;
         fcmd.exceptions(std::ios_base::failbit | std::ios_base::badbit);
         fcmd.open(analyzerInfoFile + ".clang-tidy-cmd");
-        assert(fcmd.is_open()); // If we ever disable exceptions, catch issues ASAP
 
         fcmd << istr.str();
     }

lib/summaries.cpp

@@ -89,7 +89,6 @@ std::string Summaries::create(const Tokenizer *tokenizer, const std::string &cfg
             std::ofstream fout;
             fout.exceptions(std::ios_base::failbit | std::ios_base::badbit);
             fout.open(filename);
-            assert(fout.is_open()); // If we ever disable exceptions, catch issues ASAP
 
             fout << ostr.str();
         }

test/helpers.cpp

@@ -57,7 +57,6 @@ ScopedFile::ScopedFile(std::string name, const std::string &content, std::string
     std::ofstream of;
     of.exceptions(std::ios_base::failbit | std::ios_base::badbit);
     of.open(mFullPath);
-    assert(of.is_open()); // If we ever disable exceptions, catch issues ASAP
 
     of << content;
 }

tools/dmake.cpp

@@ -219,7 +219,6 @@ static int write_vcxproj(const std::string &proj_name, const std::function<void(
     out.exceptions(std::ios_base::failbit | std::ios_base::badbit);
     // treat as binary to prevent implicit line ending conversions
     out.open(proj_name, std::ios::binary|std::ios::trunc);
-    assert(out.is_open()); // If we ever disable exceptions, catch issues ASAP
 
     out << outstr;
 
@@ -402,7 +401,6 @@ int main(int argc, char **argv)
         std::ofstream fout1;
         fout1.exceptions(std::ios_base::failbit | std::ios_base::badbit);
         fout1.open("lib/lib.pri");
-        assert(fout1.is_open()); // If we ever disable exceptions, catch issues ASAP
 
         fout1 << "# no manual edits - this file is autogenerated by dmake\n\n";
         fout1 << "include($$PWD/pcrerules.pri)\n";
@@ -427,7 +425,6 @@ int main(int argc, char **argv)
     std::ofstream fout;
     fout.exceptions(std::ios_base::failbit | std::ios_base::badbit);
     fout.open(makefile, std::ios_base::trunc);
-    assert(fout.is_open()); // If we ever disable exceptions, catch issues ASAP
 
     fout << "# This file is generated by tools/dmake, do not edit.\n\n";