Skip to content

Certain test vectors are not marked as binary #590

Description

@supsm

Describe the bug
Some test input files are not marked as binary (including but not limited to CBOR, BSON), so git will automatically add CR to any LF when cloning on windows with core.autocrlf=true, which breaks unit tests.

The files are marked as binary so git will not modify line endings.

Git modifies the line endings in the cases described above.

Enumerate the steps to reproduce the bug

  • Be on windows
  • Ensure core.autocrlf is set to true in git config (should be default)
  • Clone jsoncons
  • Build jsoncons
  • Run tests
  • Some tests fail

Include a small, self-contained example if possible
N/A

What compiler, architecture, and operating system?

  • Compiler: MSVC and GCC (wsl)
  • Architecture (e.g. x86, x64) x64
  • Operating system: Windows 11

What jsoncons library version?

  • Latest release 1.2.0
  • Other release ______
  • master

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions