Abao Tests Not Running

[NikhilPunwaney]

My Abao tests are not running: upon running the test, I get the message: Found Hookfiles: tests/raml/test_machines_hooks.js

But none of the tests run as they did before.

Nothing has changed about the hookfiles or the RAML. Please advise what could have caused this issue

[plroebuck]

Didn't provide enough information for me to help.

1. Which version of Abao? (current release: v0.5.3)
2. Node version?
3. Platform?
4. OS Version?
5. API endpoint running? Verified URL using browser or curl?
6. "None of the tests run as before" -- what does that mean? No tests run? All run but fail?
7. What did you expect to happen?
8. What actually did?

Not there with you. Screenshots always nice.

[jtodo]

I have a similar problem.

My environment is version v0.5.3, but the npm test fails.
It fails if version of underscore.js is 1.9.0, it does not seem to have failed in 1.8.3.

I’ll keep you posted.

[NikhilPunwaney]

The Abao version is 0.5.0
The Node version is v9.4.0
Platform is
OS Version 10.12.6
API endpoint is running - verified using Postman

In the past, when I ran my command abao ../raml/api.raml --hookfiles=tests/raml/test_machines_hooks.js --server http://localhost:5000

Found Hookfiles: tests/raml/test_machines_hooks.js
GET /batches -> 200
✓ Validate response code and body
.
.

However now I get:

Found Hookfiles: tests/raml/test_machines_hooks.js

1. "before all" hook
2. "after all" hook

0 passing (6ms)
2 failing

1. "before all" hook:
   TypeError: callback is not a function
   at /usr/local/lib/node_modules/abao/lib/hooks.coffee:76:16
   at /usr/local/lib/node_modules/abao/node_modules/async/dist/async.js:3888:9
   at /usr/local/lib/node_modules/abao/node_modules/async/dist/async.js:473:16
   at replenish (/usr/local/lib/node_modules/abao/node_modules/async/dist/async.js:1006:25)
   at /usr/local/lib/node_modules/abao/node_modules/async/dist/async.js:1016:9
   at eachOfLimit (/usr/local/lib/node_modules/abao/node_modules/async/dist/async.js:1041:24)
   at /usr/local/lib/node_modules/abao/node_modules/async/dist/async.js:1046:16
   at parallel (/usr/local/lib/node_modules/abao/node_modules/async/dist/async.js:3879:5)
   at Object.series (/usr/local/lib/node_modules/abao/node_modules/async/dist/async.js:4735:5)
   at Hooks.runBeforeAll (/usr/local/lib/node_modules/abao/lib/hooks.coffee:75:20)
   at Hooks.runBeforeAll (/usr/local/lib/node_modules/abao/lib/hooks.coffee:3:59)
   at Object.mocha.suite.beforeAll..bind.hooks (/usr/local/lib/node_modules/abao/lib/test-runner.coffee:103:31)
   at executeBound (/usr/local/lib/node_modules/abao/node_modules/underscore/underscore.js:758:67)
   at Context. (/usr/local/lib/node_modules/abao/node_modules/underscore/underscore.js:771:14)
   at Context. (/usr/local/lib/node_modules/abao/node_modules/underscore/underscore.js:122:29)

2. "after all" hook:
   TypeError: callback is not a function
   at /usr/local/lib/node_modules/abao/lib/hooks.coffee:82:16
   at /usr/local/lib/node_modules/abao/node_modules/async/dist/async.js:3888:9
   at /usr/local/lib/node_modules/abao/node_modules/async/dist/async.js:473:16
   at replenish (/usr/local/lib/node_modules/abao/node_modules/async/dist/async.js:1006:25)
   at /usr/local/lib/node_modules/abao/node_modules/async/dist/async.js:1016:9
   at eachOfLimit (/usr/local/lib/node_modules/abao/node_modules/async/dist/async.js:1041:24)
   at /usr/local/lib/node_modules/abao/node_modules/async/dist/async.js:1046:16
   at parallel (/usr/local/lib/node_modules/abao/node_modules/async/dist/async.js:3879:5)
   at Object.series (/usr/local/lib/node_modules/abao/node_modules/async/dist/async.js:4735:5)
   at Hooks.runAfterAll (/usr/local/lib/node_modules/abao/lib/hooks.coffee:81:20)
   at Hooks.runAfterAll (/usr/local/lib/node_modules/abao/lib/hooks.coffee:3:59)
   at Object.mocha.suite.afterAll..bind.hooks (/usr/local/lib/node_modules/abao/lib/test-runner.coffee:108:31)
   at executeBound (/usr/local/lib/node_modules/abao/node_modules/underscore/underscore.js:758:67)
   at Context. (/usr/local/lib/node_modules/abao/node_modules/underscore/underscore.js:771:14)
   at Context. (/usr/local/lib/node_modules/abao/node_modules/underscore/underscore.js:122:29)

In another branch, I only get Found Hookfiles: tests/raml/test_machines_hooks.js but am not sure what may cause the rest to stop.

I would like to run it as it was before. Right now it either doesn't run at all or throws the error as above.

[plroebuck]

@jtodo, you have the exact same error, or something else?

@NikhilPunwaney, BTW, shouldn't your hookfile be named "test_batches_hooks.js" (format: "test_<endpoint>_hooks.js")

Can either of you provide me with a copy of something I can test locally?
Would need hookfile, RAML, and copy of your endpoint code (abridged version would be fine).

[raj-bhagya]

Hi @plroebuck
Here I attached the information you asked, sharing on behalf of @NikhilPunwaney . Please let me know if you need more details.
hook_endpoint_to_test.zip

[raj-bhagya]

@plroebuck ,

Are you able to reproduce the issue? following details may help to reproduce the issue:
The Abao version is 0.5.0
The Node version is v9.4.0
Platform is OS Version 10.12.6
API endpoint is running - verified using Postman
Steps to run tests:

1. Copy attached files into a folder
2. Run following command in directory:
   abao api.raml --hookfiles=test_machines_hooks.js --server http://google.com
   hook_endpoint_to_test (1).zip

Console output:
[~/Downloads/hook_endpoint_to_test]$ abao api.raml --hookfiles=test_machines_hooks.js --server http://google.com
Found Hookfiles: test_machines_hooks.js

1. "before all" hook
2. "after all" hook

0 passing (10ms)
2 failing

1. "before all" hook:
   TypeError: callback is not a function
   at /usr/local/lib/node_modules/abao/lib/hooks.coffee:76:16
   at /usr/local/lib/node_modules/abao/node_modules/async/dist/async.js:3888:9
   at /usr/local/lib/node_modules/abao/node_modules/async/dist/async.js:473:16
   at replenish (/usr/local/lib/node_modules/abao/node_modules/async/dist/async.js:1006:25)
   at /usr/local/lib/node_modules/abao/node_modules/async/dist/async.js:1016:9
   at eachOfLimit (/usr/local/lib/node_modules/abao/node_modules/async/dist/async.js:1041:24)
   at /usr/local/lib/node_modules/abao/node_modules/async/dist/async.js:1046:16
   at parallel (/usr/local/lib/node_modules/abao/node_modules/async/dist/async.js:3879:5)
   at Object.series (/usr/local/lib/node_modules/abao/node_modules/async/dist/async.js:4735:5)
   at Hooks.runBeforeAll (/usr/local/lib/node_modules/abao/lib/hooks.coffee:75:20)
   at Hooks.runBeforeAll (/usr/local/lib/node_modules/abao/lib/hooks.coffee:3:59)
   at Object.mocha.suite.beforeAll..bind.hooks (/usr/local/lib/node_modules/abao/lib/test-runner.coffee:103:31)
   at executeBound (/usr/local/lib/node_modules/abao/node_modules/underscore/underscore.js:758:67)
   at Context. (/usr/local/lib/node_modules/abao/node_modules/underscore/underscore.js:771:14)
   at Context. (/usr/local/lib/node_modules/abao/node_modules/underscore/underscore.js:122:29)

2. "after all" hook:
   TypeError: callback is not a function
   at /usr/local/lib/node_modules/abao/lib/hooks.coffee:82:16
   at /usr/local/lib/node_modules/abao/node_modules/async/dist/async.js:3888:9
   at /usr/local/lib/node_modules/abao/node_modules/async/dist/async.js:473:16
   at replenish (/usr/local/lib/node_modules/abao/node_modules/async/dist/async.js:1006:25)
   at /usr/local/lib/node_modules/abao/node_modules/async/dist/async.js:1016:9
   at eachOfLimit (/usr/local/lib/node_modules/abao/node_modules/async/dist/async.js:1041:24)
   at /usr/local/lib/node_modules/abao/node_modules/async/dist/async.js:1046:16
   at parallel (/usr/local/lib/node_modules/abao/node_modules/async/dist/async.js:3879:5)
   at Object.series (/usr/local/lib/node_modules/abao/node_modules/async/dist/async.js:4735:5)
   at Hooks.runAfterAll (/usr/local/lib/node_modules/abao/lib/hooks.coffee:81:20)
   at Hooks.runAfterAll (/usr/local/lib/node_modules/abao/lib/hooks.coffee:3:59)
   at Object.mocha.suite.afterAll..bind.hooks (/usr/local/lib/node_modules/abao/lib/test-runner.coffee:108:31)
   at executeBound (/usr/local/lib/node_modules/abao/node_modules/underscore/underscore.js:758:67)
   at Context. (/usr/local/lib/node_modules/abao/node_modules/underscore/underscore.js:771:14)
   at Context. (/usr/local/lib/node_modules/abao/node_modules/underscore/underscore.js:122:29)

[plroebuck]

@raj-bhagya, you sent a couple Python files but nothing that I could run myself. Unable to reproduce more than a portion of the required package, I can't do anything with what you provided.

Abao-0.6.0 now builds successfully with related patches to further lockdown dependencies.
Install the new version and retry the test on your side.

[raj-bhagya]

@plroebuck , Our services are developed on Flask web application framework written in Python.

[raj-bhagya]

@plroebuck ,

I Installed latest development version Abao-0.6.0, but I'm encountering different error only with this version where as the previous version 0.5.0 is not throwing this error. I'm suspecting this could be because of node version compatibility, please suggest solution.

0.6.0 Installation output:
sudo npm install -g git+https://git@github.com/cybertk/abao.git#0.6.0
Password:
npm WARN deprecated coffee-script@1.12.7: CoffeeScript on NPM has moved to "coffeescript" (no hyphen)
/usr/local/bin/abao -> /usr/local/lib/node_modules/abao/bin/abao

• abao@0.6.0
  added 173 packages from 569 contributors in 8.551s

[/repos/simile → develop]$ npm --version
6.1.0
[/repos/simile → develop]$ node -v
v10.2.1

Error:
[~/repos/simile → develop]$ abao -v
path.js:39
throw new ERR_INVALID_ARG_TYPE('path', 'string', path);
^

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type object
at assertPath (path.js:39:11)
at Object.basename (path.js:1299:5)
at parseArgs (/usr/local/lib/node_modules/abao/lib/cli.coffee:49:17)
at Object.main (/usr/local/lib/node_modules/abao/lib/cli.coffee:67:18)
at Object. (/usr/local/lib/node_modules/abao/bin/abao:15:27)
at Module._compile (internal/modules/cjs/loader.js:702:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:713:10)
at Module.load (internal/modules/cjs/loader.js:612:32)
at tryModuleLoad (internal/modules/cjs/loader.js:551:12)
at Function.Module._load (internal/modules/cjs/loader.js:543:3)
at Function.Module.runMain (internal/modules/cjs/loader.js:744:10)
at startup (internal/bootstrap/node.js:238:19)
at bootstrapNodeJSCore (internal/bootstrap/node.js:572:3)

[plroebuck]

@raj-bhagya, I don't get an error on my side (displays usage) but to display the version type:

$ abao --version

[raj-bhagya]

Same error with abao --version also, basically getting this error with any abao command option.

[~/repos/simile/simile_web_service → develop]$ abao --version
path.js:39
throw new ERR_INVALID_ARG_TYPE('path', 'string', path);
^

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type object
at assertPath (path.js:39:11)
at Object.basename (path.js:1299:5)
at parseArgs (/usr/local/lib/node_modules/abao/lib/cli.coffee:49:17)
at Object.main (/usr/local/lib/node_modules/abao/lib/cli.coffee:67:18)
at Object. (/usr/local/lib/node_modules/abao/bin/abao:15:27)
at Module._compile (internal/modules/cjs/loader.js:702:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:713:10)
at Module.load (internal/modules/cjs/loader.js:612:32)
at tryModuleLoad (internal/modules/cjs/loader.js:551:12)
at Function.Module._load (internal/modules/cjs/loader.js:543:3)
at Function.Module.runMain (internal/modules/cjs/loader.js:744:10)
at startup (internal/bootstrap/node.js:238:19)
at bootstrapNodeJSCore (internal/bootstrap/node.js:572:3)

[plroebuck]

Line numbers don't exactly match expected, but only place basename is used in CLI is here.

Original (line 35):

  prog = path.basename pkg.bin

For quick test, change that line to be:

  prog = 'abao'

What OS version for my reference?

[raj-bhagya]

I hardcoded value to prog = 'abao' in line 35, but still same issue.
macOS 10.13.2

[plroebuck]

I'm running macOS-10.13.4 so OS-wise this code should have no problems.
I was running Node-8.11.1, but to test this I upgraded to current development version without any changes to abao-0.6.0 GitHub release.

$ node --version
v10.3.0
$ bin/abao --version
0.6.0

What is displayed for this command?

$ which abao

Should be impossible to get the same error if you replaced Line 35 above with the hardcoded value!