refactor: Replace CLI globals with context-based CLIConfig struct

- Move Version to cmd/mcs/main.go (set by ldflags)
- Create CLIConfig struct with Version, ConfigFile, NoColor fields
- Use context.Value pattern to pass config through command tree
- Update all tests to use context-based configuration
- Remove gochecknoglobals exclusion for root.go
- Add exclusion for main.go Version (required for ldflags)

This improves testability by eliminating shared mutable state.
Tests that use t.Setenv cannot run in parallel, but other tests can.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: cv

.golangci.yml

@@ -84,7 +84,13 @@ linters:
           - goconst
           - forcetypeassert
       # Global variables - justified exclusions:
-      # 1. Read-only lookup tables (RegionConfigs, screenSizes, androidVersionToSDK)
+      # 1. Version set by ldflags at build time
+      - path: cmd/mcs/main\.go
+        linters:
+          - gochecknoglobals
+        text: Version
+
+      # 3. Read-only lookup tables (RegionConfigs, screenSizes, androidVersionToSDK)
       - path: internal/api/auth\.go
         linters:
           - gochecknoglobals
@@ -94,19 +100,13 @@ linters:
           - gochecknoglobals
         text: (screenSizes|androidVersionToSDK)
 
-      # 2. CLI flags bound by Cobra framework (Version, ConfigFile, NoColor)
-      - path: internal/cli/root\.go
-        linters:
-          - gochecknoglobals
-        text: (Version|ConfigFile|NoColor)
-
-      # 3. Color state management - global state needed for CLI output formatting
+      # 4. Color state management - global state needed for CLI output formatting
       - path: internal/cli/color\.go
         linters:
           - gochecknoglobals
         text: (colorEnabled|colorMu)
 
-      # 4. Test helper mutex for serializing parallel tests
+      # 5. Test helper mutex for serializing parallel tests
       - path: internal/cli/color_test\.go
         linters:
           - gochecknoglobals

.goreleaser.yml

@@ -17,7 +17,7 @@ builds:
       - windows
       - darwin
     ldflags:
-      - -s -w -X github.com/cv/mcs/internal/cli.Version={{.Version}}
+      - -s -w -X main.Version={{.Version}}
 
 archives:
   - formats: [tar.gz]

cmd/mcs/main.go

@@ -7,8 +7,11 @@ import (
 	"github.com/cv/mcs/internal/cli"
 )
 
+// Version is set at build time via ldflags.
+var Version = "dev"
+
 func main() {
-	if err := cli.Execute(); err != nil {
+	if err := cli.Execute(Version); err != nil {
 		fmt.Fprintf(os.Stderr, "Error: %v\n", err)
 		os.Exit(1)
 	}

internal/cli/cli_config.go

@@ -0,0 +1,34 @@
+package cli
+
+import "context"
+
+// CLIConfig holds CLI configuration that was previously stored in package-level globals.
+// Using a struct allows tests to run in parallel without race conditions.
+type CLIConfig struct {
+	// Version is the CLI version, set at build time via ldflags.
+	Version string
+
+	// ConfigFile is the path to the config file, set via --config flag.
+	ConfigFile string
+
+	// NoColor disables colored output, set via --no-color flag.
+	NoColor bool
+}
+
+// cliConfigKey is the context key for CLIConfig.
+type cliConfigKey struct{}
+
+// ConfigFromContext retrieves the CLIConfig from the context.
+// Returns nil if no config is stored in the context.
+func ConfigFromContext(ctx context.Context) *CLIConfig {
+	if cfg, ok := ctx.Value(cliConfigKey{}).(*CLIConfig); ok {
+		return cfg
+	}
+
+	return nil
+}
+
+// ContextWithConfig returns a new context with the CLIConfig attached.
+func ContextWithConfig(ctx context.Context, cfg *CLIConfig) context.Context {
+	return context.WithValue(ctx, cliConfigKey{}, cfg)
+}

internal/cli/client.go

@@ -11,9 +11,16 @@ import (
 )
 
 // createAPIClient creates an API client with cached credentials if available.
-func createAPIClient() (*api.Client, error) {
-	// Load configuration
-	cfg, err := config.Load(ConfigFile)
+func createAPIClient(ctx context.Context) (*api.Client, error) {
+	// Get CLI config from context.
+	cliCfg := ConfigFromContext(ctx)
+	configFile := ""
+	if cliCfg != nil {
+		configFile = cliCfg.ConfigFile
+	}
+
+	// Load configuration.
+	cfg, err := config.Load(configFile)
 	if err != nil {
 		return nil, fmt.Errorf("failed to load config: %w", err)
 	}
@@ -79,7 +86,7 @@ type VehicleInfo struct {
 // setupVehicleClient is a shared helper that creates the API client and retrieves vehicle info.
 // It returns the authenticated client and full vehicle info, deferring cache save to the caller.
 func setupVehicleClient(ctx context.Context) (*api.Client, VehicleInfo, error) {
-	client, err := createAPIClient()
+	client, err := createAPIClient(ctx)
 	if err != nil {
 		return nil, VehicleInfo{}, err
 	}