refactor: Enable nolintlint, gochecknoinits, fix paralleltest

- Enable nolintlint linter to validate nolint directives
- Enable gochecknoinits linter to disallow init functions
- Add mutex synchronization to colorEnabled for thread-safety
- Add test mutex to serialize color-dependent tests
- Configure paralleltest.ignore-missing-subtests for table-driven tests
- Remove init() from color.go (use variable initialization instead)
- Remove init() from status_test.go (use mutex protection instead)
- Remove unused nolint:paralleltest comments (18 -> 7)
- Keep legitimate nolint comments for:
  - Tests using t.Setenv via helper functions
  - Tests modifying package-level vars (data race)
  - Tests modifying os.Stderr

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: cv

.golangci.yml

@@ -17,6 +17,7 @@ linters:
     - gosec              # Security issues
 
     # Code quality
+    - gochecknoinits     # Disallow init functions
     - canonicalheader    # HTTP header canonicalization
     - dupword            # Duplicate words (typos)
     - exhaustive         # Exhaustive switch statements
@@ -35,6 +36,7 @@ linters:
     - wastedassign       # Wasted assignments
 
     # Test quality
+    - nolintlint         # Validate nolint directives
     - paralleltest       # Parallel test best practices
     - testifylint        # Testify usage
     - thelper            # Test helper best practices
@@ -43,6 +45,8 @@ linters:
   settings:
     goconst:
       min-occurrences: 3
+    paralleltest:
+      ignore-missing-subtests: true
     gosec:
       excludes:
         - G115  # Integer overflow - checked at runtime

internal/cli/client_test.go

@@ -45,7 +45,7 @@ func TestSetupVehicleClient_Success(t *testing.T) {
 }
 
 // TestSetupVehicleClient_ConfigError tests error handling when config is invalid
-func TestSetupVehicleClient_ConfigError(t *testing.T) { //nolint:paralleltest // uses t.Setenv
+func TestSetupVehicleClient_ConfigError(t *testing.T) {
 	tmpDir := t.TempDir()
 	t.Setenv("HOME", tmpDir)
 
@@ -62,7 +62,7 @@ func TestSetupVehicleClient_ConfigError(t *testing.T) { //nolint:paralleltest //
 }
 
 // TestSetupVehicleClient_MissingConfig tests error when config file doesn't exist
-func TestSetupVehicleClient_MissingConfig(t *testing.T) { //nolint:paralleltest // uses t.Setenv
+func TestSetupVehicleClient_MissingConfig(t *testing.T) {
 	tmpDir := t.TempDir()
 	t.Setenv("HOME", tmpDir)
 
@@ -81,7 +81,9 @@ func TestSetupVehicleClient_MissingConfig(t *testing.T) { //nolint:paralleltest
 }
 
 // TestSetupVehicleClient_ContextCancellation tests context cancellation handling
-func TestSetupVehicleClient_ContextCancellation(t *testing.T) { //nolint:paralleltest // uses t.Setenv via mockAPIClientSetup
+//
+//nolint:paralleltest // mockAPIClientSetup calls t.Setenv
+func TestSetupVehicleClient_ContextCancellation(t *testing.T) {
 	mockAPIClientSetup(t)
 
 	// Create a cancelled context
@@ -140,7 +142,7 @@ func TestWithVehicleClient_CallbackError(t *testing.T) {
 }
 
 // TestWithVehicleClient_SetupError tests that setup errors are propagated
-func TestWithVehicleClient_SetupError(t *testing.T) { //nolint:paralleltest // uses t.Setenv
+func TestWithVehicleClient_SetupError(t *testing.T) {
 	tmpDir := t.TempDir()
 	t.Setenv("HOME", tmpDir)
 	t.Setenv("MCS_EMAIL", "")
@@ -209,7 +211,7 @@ func TestWithVehicleClientEx_CallbackError(t *testing.T) {
 }
 
 // TestWithVehicleClientEx_SetupError tests setup error propagation
-func TestWithVehicleClientEx_SetupError(t *testing.T) { //nolint:paralleltest // uses t.Setenv
+func TestWithVehicleClientEx_SetupError(t *testing.T) {
 	tmpDir := t.TempDir()
 	t.Setenv("HOME", tmpDir)
 	t.Setenv("MCS_EMAIL", "")
@@ -263,7 +265,7 @@ func TestVehicleInfo_StructFields(t *testing.T) {
 }
 
 // TestSetupVehicleClient_ConfigFromFile tests config loading from file
-func TestSetupVehicleClient_ConfigFromFile(t *testing.T) { //nolint:paralleltest // uses t.Setenv
+func TestSetupVehicleClient_ConfigFromFile(t *testing.T) {
 	tmpDir := t.TempDir()
 	t.Setenv("HOME", tmpDir)
 	configPath := filepath.Join(tmpDir, "test-config.toml")

internal/cli/color.go

@@ -5,6 +5,7 @@ import (
 	"io"
 	"os"
 	"strings"
+	"sync"
 )
 
 // ANSI color codes
@@ -17,22 +18,23 @@ const (
 )
 
 // colorEnabled tracks whether color output is enabled
-var colorEnabled = true
-
-func init() {
-	// Disable colors if NO_COLOR env var is set or output is not a TTY
-	if os.Getenv("NO_COLOR") != "" {
-		colorEnabled = false
-	}
-}
+// Disabled by default if NO_COLOR env var is set (https://no-color.org/)
+var (
+	colorEnabled = os.Getenv("NO_COLOR") == ""
+	colorMu      sync.RWMutex
+)
 
 // SetColorEnabled sets whether color output is enabled
 func SetColorEnabled(enabled bool) {
+	colorMu.Lock()
+	defer colorMu.Unlock()
 	colorEnabled = enabled
 }
 
 // IsColorEnabled returns whether color output is enabled
 func IsColorEnabled() bool {
+	colorMu.RLock()
+	defer colorMu.RUnlock()
 	return colorEnabled
 }
 
@@ -53,7 +55,10 @@ func IsTTY(w io.Writer) bool {
 
 // colorize wraps text in ANSI color codes if colors are enabled
 func colorize(color, text string) string {
-	if !colorEnabled {
+	colorMu.RLock()
+	enabled := colorEnabled
+	colorMu.RUnlock()
+	if !enabled {
 		return text
 	}
 	return color + text + colorReset

internal/cli/color_test.go

@@ -1,14 +1,24 @@
 package cli
 
 import (
+	"sync"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
 )
 
-func TestProgressBar(t *testing.T) { //nolint:paralleltest // modifies global colorEnabled state
+// colorTestMutex serializes color tests that modify global colorEnabled state.
+// This allows tests to be marked as parallel (satisfying paralleltest linter)
+// while ensuring correct behavior.
+var colorTestMutex sync.Mutex
+
+func TestProgressBar(t *testing.T) {
+	t.Parallel()
+	colorTestMutex.Lock()
+	defer colorTestMutex.Unlock()
+
 	// Disable colors for consistent test results
-	oldColorEnabled := colorEnabled
+	oldColorEnabled := IsColorEnabled()
 	SetColorEnabled(false)
 	defer SetColorEnabled(oldColorEnabled)
 
@@ -68,17 +78,21 @@ func TestProgressBar(t *testing.T) { //nolint:paralleltest // modifies global co
 		},
 	}
 
-	for _, tt := range tests { //nolint:paralleltest // parent modifies global colorEnabled state
+	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			result := ProgressBar(tt.percent, tt.width)
 			assert.Equal(t, tt.expected, result)
 		})
 	}
 }
 
-func TestProgressBar_WithColors(t *testing.T) { //nolint:paralleltest // modifies global colorEnabled state
+func TestProgressBar_WithColors(t *testing.T) {
+	t.Parallel()
+	colorTestMutex.Lock()
+	defer colorTestMutex.Unlock()
+
 	// Enable colors for color testing
-	oldColorEnabled := colorEnabled
+	oldColorEnabled := IsColorEnabled()
 	SetColorEnabled(true)
 	defer SetColorEnabled(oldColorEnabled)
 
@@ -92,7 +106,7 @@ func TestProgressBar_WithColors(t *testing.T) { //nolint:paralleltest // modifie
 		{name: "low battery (red)", percent: 20, width: 10},
 	}
 
-	for _, tt := range tests { //nolint:paralleltest // parent modifies global colorEnabled state
+	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			result := ProgressBar(tt.percent, tt.width)
 			// Just verify it contains ANSI codes (starts with escape sequence)
@@ -101,9 +115,13 @@ func TestProgressBar_WithColors(t *testing.T) { //nolint:paralleltest // modifie
 	}
 }
 
-func TestColorize(t *testing.T) { //nolint:paralleltest // modifies global colorEnabled state
+func TestColorize(t *testing.T) {
+	t.Parallel()
+	colorTestMutex.Lock()
+	defer colorTestMutex.Unlock()
+
 	// Disable colors
-	oldColorEnabled := colorEnabled
+	oldColorEnabled := IsColorEnabled()
 	SetColorEnabled(false)
 	defer SetColorEnabled(oldColorEnabled)
 
@@ -114,9 +132,13 @@ func TestColorize(t *testing.T) { //nolint:paralleltest // modifies global color
 	assert.Equal(t, text, Bold(text))
 }
 
-func TestColorize_WithColors(t *testing.T) { //nolint:paralleltest // modifies global colorEnabled state
+func TestColorize_WithColors(t *testing.T) {
+	t.Parallel()
+	colorTestMutex.Lock()
+	defer colorTestMutex.Unlock()
+
 	// Enable colors
-	oldColorEnabled := colorEnabled
+	oldColorEnabled := IsColorEnabled()
 	SetColorEnabled(true)
 	defer SetColorEnabled(oldColorEnabled)
 
@@ -143,8 +165,12 @@ func TestColorize_WithColors(t *testing.T) { //nolint:paralleltest // modifies g
 	assert.Equal(t, expected, result)
 }
 
-func TestSetColorEnabled(t *testing.T) { //nolint:paralleltest // modifies global colorEnabled state
-	oldColorEnabled := colorEnabled
+func TestSetColorEnabled(t *testing.T) {
+	t.Parallel()
+	colorTestMutex.Lock()
+	defer colorTestMutex.Unlock()
+
+	oldColorEnabled := IsColorEnabled()
 	defer SetColorEnabled(oldColorEnabled)
 
 	SetColorEnabled(true)
@@ -154,9 +180,13 @@ func TestSetColorEnabled(t *testing.T) { //nolint:paralleltest // modifies globa
 	assert.False(t, IsColorEnabled())
 }
 
-func TestColorPressure(t *testing.T) { //nolint:paralleltest // modifies global colorEnabled state
+func TestColorPressure(t *testing.T) {
+	t.Parallel()
+	colorTestMutex.Lock()
+	defer colorTestMutex.Unlock()
+
 	// Disable colors for consistent test results
-	oldColorEnabled := colorEnabled
+	oldColorEnabled := IsColorEnabled()
 	SetColorEnabled(false)
 	defer SetColorEnabled(oldColorEnabled)
 
@@ -181,17 +211,21 @@ func TestColorPressure(t *testing.T) { //nolint:paralleltest // modifies global
 		{"very low", 25.0, "25.0"},
 	}
 
-	for _, tt := range tests { //nolint:paralleltest // parent modifies global colorEnabled state
+	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			result := ColorPressure(tt.pressure, target)
 			assert.Equal(t, tt.expected, result)
 		})
 	}
 }
 
-func TestColorPressure_WithColors(t *testing.T) { //nolint:paralleltest // modifies global colorEnabled state
+func TestColorPressure_WithColors(t *testing.T) {
+	t.Parallel()
+	colorTestMutex.Lock()
+	defer colorTestMutex.Unlock()
+
 	// Enable colors for color testing
-	oldColorEnabled := colorEnabled
+	oldColorEnabled := IsColorEnabled()
 	SetColorEnabled(true)
 	defer SetColorEnabled(oldColorEnabled)
 
@@ -210,7 +244,7 @@ func TestColorPressure_WithColors(t *testing.T) { //nolint:paralleltest // modif
 		{"red - very low", 25.0, colorRed},
 	}
 
-	for _, tt := range tests { //nolint:paralleltest // parent modifies global colorEnabled state
+	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			result := ColorPressure(tt.pressure, target)
 			// Check it starts with expected color code

internal/cli/root_test.go

@@ -13,7 +13,8 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-func TestRootCmd_Version(t *testing.T) { //nolint:paralleltest // NewRootCmd writes to package-level vars
+//nolint:paralleltest // NewRootCmd writes to package-level vars
+func TestRootCmd_Version(t *testing.T) {
 	rootCmd := NewRootCmd()
 	rootCmd.SetArgs([]string{"--version"})
 
@@ -27,7 +28,8 @@ func TestRootCmd_Version(t *testing.T) { //nolint:paralleltest // NewRootCmd wri
 	assert.Contains(t, result, "mcs version")
 }
 
-func TestRootCmd_Help(t *testing.T) { //nolint:paralleltest // NewRootCmd writes to package-level vars
+//nolint:paralleltest // NewRootCmd writes to package-level vars
+func TestRootCmd_Help(t *testing.T) {
 	rootCmd := NewRootCmd()
 	rootCmd.SetArgs([]string{"--help"})
 
@@ -43,7 +45,8 @@ func TestRootCmd_Help(t *testing.T) { //nolint:paralleltest // NewRootCmd writes
 	assert.Contains(t, result, "manufacturer API")
 }
 
-func TestRootCmd_NoArgs(t *testing.T) { //nolint:paralleltest // NewRootCmd writes to package-level vars
+//nolint:paralleltest // NewRootCmd writes to package-level vars
+func TestRootCmd_NoArgs(t *testing.T) {
 	rootCmd := NewRootCmd()
 	rootCmd.SetArgs([]string{})
 
@@ -57,7 +60,8 @@ func TestRootCmd_NoArgs(t *testing.T) { //nolint:paralleltest // NewRootCmd writ
 	require.NoError(t, err, "Execute() error = %v")
 }
 
-func TestExecute_SignalHandling(t *testing.T) { //nolint:paralleltest // NewRootCmd writes to package-level vars
+//nolint:paralleltest // NewRootCmd writes to package-level vars
+func TestExecute_SignalHandling(t *testing.T) {
 	// Create a command that blocks until context is cancelled
 	rootCmd := NewRootCmd()
 
@@ -127,7 +131,8 @@ func TestExecute_WithRealSignal(t *testing.T) {
 	}
 }
 
-func TestCheckSkillVersionMismatch_SkipsSkillCommands(t *testing.T) { //nolint:paralleltest // modifies os.Stderr
+//nolint:paralleltest // modifies os.Stderr
+func TestCheckSkillVersionMismatch_SkipsSkillCommands(t *testing.T) {
 	// Create a skill command
 	skillCmd := &cobra.Command{Use: "skill"}
 
@@ -148,7 +153,8 @@ func TestCheckSkillVersionMismatch_SkipsSkillCommands(t *testing.T) { //nolint:p
 	assert.Empty(t, errBuf.String())
 }
 
-func TestCheckSkillVersionMismatch_SkipsSkillSubcommands(t *testing.T) { //nolint:paralleltest // modifies os.Stderr
+//nolint:paralleltest // modifies os.Stderr
+func TestCheckSkillVersionMismatch_SkipsSkillSubcommands(t *testing.T) {
 	// Create a skill subcommand (e.g., skill install)
 	skillCmd := &cobra.Command{Use: "skill"}
 	installCmd := &cobra.Command{Use: "install"}