Skip to content

Conversation

@greysonlalonde
Copy link
Contributor

@greysonlalonde greysonlalonde commented Nov 29, 2025

fixes #3953


Note

Use explicit 1-indexed task_number to map planning outputs to tasks, handling out-of-order, missing, and duplicate plans; update models, defaults, and tests.

  • Planning pipeline:
    • Map plans to tasks via task_number instead of list order in Crew._handle_crew_planning, appending matching plans and logging warnings for missing/duplicate task numbers.
    • Require task_number: int in PlanPerTask; update PlannerTaskPydanticOutput usage accordingly.
    • Set default planning LLM to gpt-4o-mini in CrewPlanner.
  • Task summary generation:
    • Include agent knowledge (when present) and serialize agent/tool info more robustly in _create_tasks_summary.
  • Tests:
    • Add integration tests verifying out-of-order mapping, missing-plan handling, description preservation, and duplicate-number behavior.
    • Update unit tests to use task_number, mock knowledge sources, and check LLM default.
  • Minor:
    • Clean up EventListener() instantiation (remove type ignore).

Written by Cursor Bugbot for commit 11d1088. This will update automatically on new commits. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on December 28

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@greysonlalonde greysonlalonde requested a review from a team November 29, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Task planner ends up with wrong order of tasks

2 participants