refactor(engine): drop dead Insecure field from Options

The field has been declared on engine.Options since the file was created
(c567135, 2024-05) but was never read by Render or any helper. apply.go
and template.go were assigning it from their respective --insecure flags;
apply_test.go asserted the assignment. Nothing else looked at the value.

The runtime guarantee — --insecure (maintenance mode) bypasses
FailIfMultiNodes — is provided by WithClientMaintenance not injecting
nodes into the gRPC context, not by anything inside engine.Render. The
dead field added nothing on top of that.

Drop the field, the assignments, and the assertion. golangci-lint is
clean.

Closes #123

Assisted-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>

Author: lexfrei

pkg/commands/apply.go

@@ -214,7 +214,6 @@ func withApplyClient(f func(ctx context.Context, c *client.Client) error) error
 func buildApplyRenderOptions(modelineTemplates []string, withSecretsPath string) engine.Options {
 	resolvedTemplates := resolveTemplatePaths(modelineTemplates, Config.RootDir)
 	return engine.Options{
-		Insecure:          applyCmdFlags.insecure,
 		TalosVersion:      applyCmdFlags.talosVersion,
 		WithSecrets:       withSecretsPath,
 		KubernetesVersion: applyCmdFlags.kubernetesVersion,

pkg/commands/apply_test.go

@@ -15,20 +15,17 @@ func TestBuildApplyRenderOptions(t *testing.T) {
 	origTalosVersion := applyCmdFlags.talosVersion
 	origKubeVersion := applyCmdFlags.kubernetesVersion
 	origDebug := applyCmdFlags.debug
-	origInsecure := applyCmdFlags.insecure
 	origRootDir := Config.RootDir
 	defer func() {
 		applyCmdFlags.talosVersion = origTalosVersion
 		applyCmdFlags.kubernetesVersion = origKubeVersion
 		applyCmdFlags.debug = origDebug
-		applyCmdFlags.insecure = origInsecure
 		Config.RootDir = origRootDir
 	}()
 
 	applyCmdFlags.talosVersion = "v1.12"
 	applyCmdFlags.kubernetesVersion = "1.31.0"
 	applyCmdFlags.debug = false
-	applyCmdFlags.insecure = true
 	Config.RootDir = "/project"
 
 	opts := buildApplyRenderOptions(
@@ -42,9 +39,6 @@ func TestBuildApplyRenderOptions(t *testing.T) {
 	if opts.Offline {
 		t.Error("expected Offline=false for online template rendering path")
 	}
-	if !opts.Insecure {
-		t.Error("expected Insecure=true to be passed through from flags")
-	}
 	if opts.Root != "/project" {
 		t.Errorf("expected Root=/project, got %s", opts.Root)
 	}

pkg/commands/template.go

@@ -274,7 +274,6 @@ func generateOutput(ctx context.Context, c *client.Client, args []string) (strin
 	}
 
 	opts := engine.Options{
-		Insecure:          templateCmdFlags.insecure,
 		ValueFiles:        templateCmdFlags.valueFiles,
 		StringValues:      templateCmdFlags.stringValues,
 		Values:            templateCmdFlags.values,

pkg/engine/engine.go

@@ -40,7 +40,6 @@ import (
 
 // Options encapsulates all parameters necessary for rendering.
 type Options struct {
-	Insecure          bool
 	ValueFiles        []string
 	StringValues      []string
 	Values            []string