refactor(engine): drop unused ctx parameter from FullConfigProcess

FullConfigProcess took a context.Context that it never observed —
the function performs no I/O respecting cancellation. The "_"
parameter masked an honest API: callers were passing live contexts
to a function that discarded them, which is misleading review
surface.

Drop the parameter from FullConfigProcess and propagate to its
two callers (apply.applyOneFileDirectPatchMode,
upgrade_handler) plus the four FullConfigProcess contract tests.
The upgrade handler also drops a now-orphaned context.Background()
allocation and the unused "context" import; the apply path drops
the now-unused ctx threading down to applyOneFileDirectPatchMode
which had been carrying it for this single FullConfigProcess call.

If a future configpatcher needs cancellation, reintroduce ctx
typed as the first argument.

Signed-off-by: Aleksei Sviridkin <f@lex.la>

Author: lexfrei

pkg/commands/upgrade_handler.go

@@ -15,7 +15,6 @@
 package commands
 
 import (
-	"context"
 	"fmt"
 	"os"
 
@@ -94,7 +93,6 @@ func wrapUpgradeCommand(wrappedCmd *cobra.Command, originalRunE func(*cobra.Comm
 			}
 
 			// Process config to extract image
-			ctx := context.Background()
 			eopts := engine.Options{
 				TalosVersion:      talosVersion,
 				WithSecrets:       withSecrets,
@@ -103,7 +101,7 @@ func wrapUpgradeCommand(wrappedCmd *cobra.Command, originalRunE func(*cobra.Comm
 
 			patches := []string{"@" + configFile}
 
-			configBundle, machineType, err := engine.FullConfigProcess(ctx, eopts, patches)
+			configBundle, machineType, err := engine.FullConfigProcess(eopts, patches)
 			if err != nil {
 				return errors.Wrap(err, "full config processing error")
 			}

pkg/engine/contract_render_test.go

@@ -266,7 +266,7 @@ func TestContract_SerializeConfiguration_ControlplaneVsWorker(t *testing.T) {
 // machine.TypeUnknown — a reduced state operators do not normally
 // reach.
 func TestContract_FullConfigProcess_NoPatchesUsesBundleDefault(t *testing.T) {
-	bundle, mtype, err := FullConfigProcess(context.Background(), Options{}, nil)
+	bundle, mtype, err := FullConfigProcess(Options{}, nil)
 	if err != nil {
 		t.Fatalf("FullConfigProcess: %v", err)
 	}
@@ -286,7 +286,7 @@ func TestContract_FullConfigProcess_NoPatchesUsesBundleDefault(t *testing.T) {
 // own machineType inference does not interfere.
 func TestContract_FullConfigProcess_ControlplaneFromPatch(t *testing.T) {
 	patch := "machine:\n  type: controlplane\n"
-	_, mtype, err := FullConfigProcess(context.Background(), Options{}, []string{patch})
+	_, mtype, err := FullConfigProcess(Options{}, []string{patch})
 	if err != nil {
 		t.Fatalf("FullConfigProcess: %v", err)
 	}
@@ -300,7 +300,7 @@ func TestContract_FullConfigProcess_ControlplaneFromPatch(t *testing.T) {
 // silently swallows malformed patches surfaces here.
 func TestContract_FullConfigProcess_MalformedPatchError(t *testing.T) {
 	bad := "this is not valid YAML\n  : :"
-	_, _, err := FullConfigProcess(context.Background(), Options{}, []string{bad})
+	_, _, err := FullConfigProcess(Options{}, []string{bad})
 	if err == nil {
 		t.Fatal("expected error for malformed patch")
 	}
@@ -309,7 +309,7 @@ func TestContract_FullConfigProcess_MalformedPatchError(t *testing.T) {
 // Contract: FullConfigProcess with a malformed TalosVersion option
 // surfaces InitializeConfigBundle's error path.
 func TestContract_FullConfigProcess_BadTalosVersionError(t *testing.T) {
-	_, _, err := FullConfigProcess(context.Background(), Options{TalosVersion: "garbage"}, nil)
+	_, _, err := FullConfigProcess(Options{TalosVersion: "garbage"}, nil)
 	if err == nil {
 		t.Fatal("expected error")
 	}

pkg/engine/engine.go

@@ -120,8 +120,14 @@ func debugPhase(opts Options, patches []string, clusterName string, clusterEndpo
 
 // FullConfigProcess handles the full process of creating and updating the Bundle.
 //
+// The function performs no I/O that would respect a context; the
+// ctx parameter that callers used to pass in was always discarded
+// inside. Dropping the parameter makes the contract honest. If a
+// future caller needs cancellation (e.g. a future remote
+// configpatcher), reintroduce it as a typed first argument.
+//
 //nolint:gocritic // hugeParam: Options is the package's public facing configuration carrier; converting this to a pointer would propagate the change across every caller in pkg/commands and break the API for external consumers.
-func FullConfigProcess(_ context.Context, opts Options, patches []string) (*bundle.Bundle, machine.Type, error) {
+func FullConfigProcess(opts Options, patches []string) (*bundle.Bundle, machine.Type, error) {
 	configBundle, err := InitializeConfigBundle(opts)
 	if err != nil {
 		return nil, machine.TypeUnknown, errors.Wrap(err, "initial config bundle error")