fix(charts,test): nil-safe floatingIP validation; replace Russian comment fragment

Two findings from review:

1. nil .Values.floatingIP (operator unset, Helm-coalesced
   value-table miss, --set floatingIP=null) tripped the
   fail-fast block. Sprig's `nil | toString` returns the
   literal string "<nil>", which is truthy AND not a valid IP
   — so feeding the toString'd value through ipIsValid below
   would fail-fast on every controlplane render where the
   operator legitimately left floatingIP unset
   (single-node clusters, LB-fronted multi-node, anything Helm
   strips out of the values table).

   Gate on the RAW .Values.floatingIP truthiness first;
   coerce through toString INSIDE the gated body, where the
   numeric-scalar safety net still fires. Both charts.

   Pinned by
   TestContract_NetworkMultidoc_VIPGracefulWhenFloatingIPNil
   plus its Generic_ mirror: nil floatingIP must render
   cleanly with no Layer2VIPConfig and no "<nil>" leakage in
   the rendered YAML.

2. One inline test comment contained the Russian verb
   "pin'ит" mid-sentence. Replace with the English "pins" —
   committed-text English-only rule per public-content
   convention.

Signed-off-by: Aleksei Sviridkin <f@lex.la>

Author: lexfrei

charts/cozystack/templates/_helpers.tpl

@@ -207,18 +207,29 @@ nameservers:
        Render-time `fail` with the bad value is much cheaper to
        debug.
 
-       Coerce through `toString` BEFORE the predicate. An unquoted
-       numeric YAML scalar (`floatingIP: 192168`) parses as int,
-       and ipIsValid is a Go function with a string parameter —
-       passing an int would raise the Go-template
+       Gate on the RAW .Values.floatingIP first: nil and missing
+       fields are falsy on the raw value but Sprig's `nil |
+       toString` returns the literal string "<nil>" — truthy and
+       not a valid IP, so feeding it to ipIsValid below would
+       fail-fast on every controlplane render where the operator
+       left floatingIP unset (single-node clusters, LB-fronted
+       multi-node, anything Helm coalesces out of the values
+       table).
+
+       Then coerce through toString INSIDE the gated body. An
+       unquoted numeric YAML scalar (floatingIP: 192168) parses
+       as int, and ipIsValid is a Go function with a string
+       parameter — passing an int would raise the Go-template
        "wrong type for value; expected string; got int" panic
-       instead of the friendly fail message. The toString is also
-       the safety net for any future operator yaml shape we have
-       not yet thought of. */}}
+       instead of the friendly fail message. The toString
+       coercion is also the safety net for any future operator
+       yaml shape we have not yet thought of. */}}
+{{- if and .Values.floatingIP (eq .MachineType "controlplane") }}
 {{- $fipStr := .Values.floatingIP | toString }}
-{{- if and $fipStr (not (ipIsValid $fipStr)) (eq .MachineType "controlplane") }}
+{{- if not (ipIsValid $fipStr) }}
 {{- fail (printf "talm: floatingIP %q is not a valid IPv4 / IPv6 literal. Edit values.yaml and re-run." $fipStr) }}
 {{- end }}
+{{- end }}
 {{- /* Operator-declared vipLink override: emit Layer2VIPConfig
        regardless of discovery state. Useful when the target link
        does not yet exist on the live system at first apply (typical

charts/generic/templates/_helpers.tpl

@@ -131,18 +131,29 @@ nameservers:
        Render-time `fail` with the bad value is much cheaper to
        debug.
 
-       Coerce through `toString` BEFORE the predicate. An unquoted
-       numeric YAML scalar (`floatingIP: 192168`) parses as int,
-       and ipIsValid is a Go function with a string parameter —
-       passing an int would raise the Go-template
+       Gate on the RAW .Values.floatingIP first: nil and missing
+       fields are falsy on the raw value but Sprig's `nil |
+       toString` returns the literal string "<nil>" — truthy and
+       not a valid IP, so feeding it to ipIsValid below would
+       fail-fast on every controlplane render where the operator
+       left floatingIP unset (single-node clusters, LB-fronted
+       multi-node, anything Helm coalesces out of the values
+       table).
+
+       Then coerce through toString INSIDE the gated body. An
+       unquoted numeric YAML scalar (floatingIP: 192168) parses
+       as int, and ipIsValid is a Go function with a string
+       parameter — passing an int would raise the Go-template
        "wrong type for value; expected string; got int" panic
-       instead of the friendly fail message. The toString is also
-       the safety net for any future operator yaml shape we have
-       not yet thought of. */}}
+       instead of the friendly fail message. The toString
+       coercion is also the safety net for any future operator
+       yaml shape we have not yet thought of. */}}
+{{- if and .Values.floatingIP (eq .MachineType "controlplane") }}
 {{- $fipStr := .Values.floatingIP | toString }}
-{{- if and $fipStr (not (ipIsValid $fipStr)) (eq .MachineType "controlplane") }}
+{{- if not (ipIsValid $fipStr) }}
 {{- fail (printf "talm: floatingIP %q is not a valid IPv4 / IPv6 literal. Edit values.yaml and re-run." $fipStr) }}
 {{- end }}
+{{- end }}
 {{- /* Operator-declared vipLink override: emit Layer2VIPConfig
        regardless of discovery state. Useful when the target link
        does not yet exist on the live system at first apply (typical

pkg/engine/contract_network_multidoc_test.go

@@ -266,7 +266,7 @@ func TestContract_NetworkMultidoc_BridgeConfigEmitted(t *testing.T) {
 // Fixture: bridgeWithClusterSubnetLookup has br0 carrying
 // 10.5.0.10/24 (global scope) and the IPv4 default route. floatingIP
 // 10.5.0.99 is inside that subnet, so link_name_for_address resolves
-// to br0; the discovery-derived Layer2VIPConfig pin'ит link=br0.
+// to br0; the discovery-derived Layer2VIPConfig pins link=br0.
 // Without BridgeConfig emission (the prior shape), this would have
 // been a "VIP on undocumented link" symptom; now BridgeConfig
 // documents the link explicitly and the chart also emits STP
@@ -774,6 +774,43 @@ func TestContract_NetworkMultidoc_VIPEmitsWithMatchingSubnetEvenWithoutDefaultRo
 	}
 }
 
+// Contract: a nil / unset floatingIP on a controlplane node
+// renders without error and emits no Layer2VIPConfig. The
+// validation block must gate on the RAW .Values.floatingIP
+// truthiness before any toString coercion — Sprig's
+// `nil | toString` returns the literal string "<nil>", which is
+// truthy and not a valid IP, so a naive predicate on the
+// toString'd value would fail-fast on every controlplane render
+// where the operator left floatingIP unset (single-node
+// clusters, LB-fronted multi-node, anything Helm coalesces out
+// of the values table).
+func TestContract_NetworkMultidoc_VIPGracefulWhenFloatingIPNil(t *testing.T) {
+	out := renderCozystackWith(t, hetznerPublicNICWithPrivateVLANLookup(), map[string]any{
+		"floatingIP":        nil,
+		"advertisedSubnets": []any{testAdvertisedSubnet},
+	})
+	if strings.Contains(out, "kind: Layer2VIPConfig") {
+		t.Errorf("Layer2VIPConfig must not emit when floatingIP is nil; got:\n%s", out)
+	}
+	if strings.Contains(out, "<nil>") {
+		t.Errorf("rendered output leaks the Sprig <nil> literal — fail-fast misfired on nil floatingIP:\n%s", out)
+	}
+}
+
+// Generic-chart mirror of the nil-safe contract above.
+func TestContract_NetworkMultidoc_Generic_VIPGracefulWhenFloatingIPNil(t *testing.T) {
+	out := renderGenericWith(t, hetznerPublicNICWithPrivateVLANLookup(), map[string]any{
+		"floatingIP":        nil,
+		"advertisedSubnets": []any{testAdvertisedSubnet},
+	})
+	if strings.Contains(out, "kind: Layer2VIPConfig") {
+		t.Errorf("generic chart: Layer2VIPConfig must not emit when floatingIP is nil; got:\n%s", out)
+	}
+	if strings.Contains(out, "<nil>") {
+		t.Errorf("generic chart: rendered output leaks the Sprig <nil> literal:\n%s", out)
+	}
+}
+
 // Contract: a numeric (non-string) floatingIP — typed without
 // quotes in values.yaml so YAML parses it as int — must produce
 // the friendly fail-fast error, NOT a Go-template