Skip to content

Commit cf83344

Browse files
committed
chore: Per PR review, do not include system site-backages, use symlinks, and remove self.venv assignment
Signed-off-by: habeck <habeck@us.ibm.com>
1 parent 418fb63 commit cf83344

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

cpex/framework/isolated/client.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -177,9 +177,9 @@ async def create_venv(
177177

178178
# Create the EnvBuilder with common options
179179
builder = venv.EnvBuilder(
180-
system_site_packages=True, # Don't include system site-packages
180+
system_site_packages=False, # Don't include system site-packages
181181
clear=False, # Don't clear existing venv if it exists
182-
symlinks=False, # Use symlinks (recommended on Unix-like systems)
182+
symlinks=True, # Use symlinks (recommended on Unix-like systems)
183183
upgrade=False, # Don't upgrade existing venv
184184
with_pip=True, # Install pip in the venv
185185
prompt=None, # Use default prompt (directory name)
@@ -210,7 +210,7 @@ async def initialize(self) -> None:
210210
requirements_file = self.plugin_path / self.config.config["requirements_file"]
211211

212212
# Create venv with caching support
213-
self.venv = await self.create_venv(venv_path=venv_path, requirements_file=requirements_file, use_cache=True)
213+
await self.create_venv(venv_path=venv_path, requirements_file=requirements_file, use_cache=True)
214214

215215
self.comm = VenvProcessCommunicator(venv_path)
216216

0 commit comments

Comments
 (0)