Skip to content

Commit 8c1830b

Browse files
author
Bogdan-Marius-Catanus
committed
refactor: use get_settings().log_level instead of hardcoded env var
Address PR review feedback to use the settings infrastructure instead of directly accessing environment variables. This approach: - Keeps the env var name defined in one place (PluginsSettings model) - Gets .env file support for free - Stays consistent with how other settings are read in the codebase Changes: - grpc/server/runtime.py: Use get_settings().log_level with fallback to args - mcp/server/runtime.py: Use get_settings().log_level - unix/server/runtime.py: Use get_settings().log_level
1 parent 5540815 commit 8c1830b

3 files changed

Lines changed: 11 additions & 7 deletions

File tree

cpex/framework/external/grpc/server/runtime.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -290,8 +290,9 @@ def main() -> None:
290290
args = parser.parse_args()
291291

292292
# Configure logging - respect PLUGINS_LOG_LEVEL environment variable
293-
log_level_str = os.getenv("PLUGINS_LOG_LEVEL", args.log_level).upper()
294-
log_level = getattr(logging, log_level_str, logging.INFO)
293+
settings = get_settings()
294+
log_level_str = settings.log_level or args.log_level
295+
log_level = getattr(logging, log_level_str.upper(), logging.INFO)
295296
logging.basicConfig(
296297
level=log_level,
297298
format="%(asctime)s - %(name)s - %(levelname)s - %(message)s",

cpex/framework/external/mcp/server/runtime.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,11 +79,13 @@
7979
MCP_SERVER_INSTRUCTIONS,
8080
MCP_SERVER_NAME,
8181
)
82-
from cpex.framework.settings import get_transport_settings
8382

8483
# Configure logging - respect PLUGINS_LOG_LEVEL environment variable
85-
log_level_str = os.getenv("PLUGINS_LOG_LEVEL", "INFO").upper()
86-
log_level = getattr(logging, log_level_str, logging.INFO)
84+
from cpex.framework.settings import get_settings, get_transport_settings
85+
86+
settings = get_settings()
87+
log_level_str = settings.log_level
88+
log_level = getattr(logging, log_level_str.upper(), logging.INFO)
8789
logging.basicConfig(
8890
level=log_level,
8991
format="%(asctime)s - %(name)s - %(levelname)s - %(message)s",

cpex/framework/external/unix/server/runtime.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,9 @@
3434
from cpex.framework.settings import get_settings
3535

3636
# Configure logging - respect PLUGINS_LOG_LEVEL environment variable
37-
log_level_str = os.getenv("PLUGINS_LOG_LEVEL", "INFO").upper()
38-
log_level = getattr(logging, log_level_str, logging.INFO)
37+
settings = get_settings()
38+
log_level_str = settings.log_level
39+
log_level = getattr(logging, log_level_str.upper(), logging.INFO)
3940
logging.basicConfig(
4041
level=log_level,
4142
format="%(asctime)s - %(name)s - %(levelname)s - %(message)s",

0 commit comments

Comments
 (0)