fix: Improve context path handling custom Dockerfiles #1340
+120
−39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed an issue that occurred in
v1.5.0.When I built the
AutoGPTproject using podman-compose, I encountered the following problem:Here's a fragment of the
docker-compose.ymlfile inAutoGPT/autogpt_platform/:I wrote some tests for
container_to_build_args()function inpodman_compose.pyand found that it always concatenated thecontextpath twice as the prefix of dockerfile path. For example, when I usedcontext: subdir/,container_to_build_args()would generate build args like... -f subdir/subdir/<dockerfile> ...There are two different logical dockerfile paths when handling the
-f, --filebuild argument with a local context (i.e., when the build context comes from the local filesystem):cwdwhere thepodman-composecommand is run.-fbuild arg: the file path should be relative to the context root.I fixed this issue and also added test cases to cover these scenarios.