more coverage

Author: tim-vk

dockerfile_parse/util.py

@@ -388,6 +388,8 @@ def parse(cls, image_name):
 
     def to_str(self, registry=True, tag=True, explicit_tag=False,
                explicit_namespace=False):
+        if self.repo is None:
+            raise RuntimeError('No image repository specified')
 
         result = self.get_repo(explicit_namespace)
 

tests/test_parser.py

@@ -69,8 +69,26 @@ def test_util_image_name_get_repo(self, image_string, dictionary):
 
     def test_util_image_name_to_str(self, image_string, dictionary):
         image = ImageName.parse(image_string)
-        assert image.to_str() == (image_string.lstrip('/') if image_string else None)
-        assert image.to_str(explicit_tag=True) == image_string.lstrip('/') + (':latest' if dictionary["tag"] is None else "")
+        if dictionary["repo"] is None:
+            with pytest.raises(RuntimeError):
+                image.to_str()
+        else:
+            assert image.to_str() == image_string.lstrip('/')
+            assert image.to_str() == (image_string.lstrip('/') if image_string else None)
+            assert image.to_str(explicit_tag=True) == \
+                   image_string.lstrip('/') + (':latest' if dictionary["tag"] is None else "")
+
+    def test_image_name_hash(self, image_string, dictionary):
+        image = ImageName.parse(image_string)
+        if dictionary["repo"] is None:
+            with pytest.raises(RuntimeError):
+                hash(image)
+        else:
+            hash(image)
+
+    def test_image_name_repr(self, image_string, dictionary):
+        image = ImageName.parse(image_string)
+        repr(image)
 
     def test_image_name_comparison(self, image_string, dictionary):
         # make sure that "==" is implemented correctly on both Python major releases
@@ -120,11 +138,6 @@ def test_image_name_enclose(repo, organization, enclosed_repo, registry, tag):
     assert image_name.registry == registry
     assert image_name.tag == tag
 
-def test_image_name_hash():
-    hash(ImageName("Hello"))
-
-def test_image_name_repr():
-    repr(ImageName("World"))
 
 class TestDockerfileParser(object):
     def test_all_versions_match(self):