From d445115be600bd2ae79c7a4a2e0a74e945ce0dfc Mon Sep 17 00:00:00 2001 From: Adam Date: Thu, 18 Sep 2025 21:11:29 +0200 Subject: [PATCH 1/2] remove lodash.map --- engine.js | 10 ++++------ package-lock.json | 1 - package.json | 1 - 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/engine.js b/engine.js index 24a42b7c..9cdb78ce 100644 --- a/engine.js +++ b/engine.js @@ -1,7 +1,6 @@ 'format cjs'; var wrap = require('word-wrap'); -var map = require('lodash.map'); var longest = require('longest'); var chalk = require('chalk'); @@ -37,12 +36,11 @@ var filterSubject = function(subject, disableSubjectLowerCase) { // We use Commonjs here, but ES6 or AMD would do just // fine. module.exports = function(options) { - var types = options.types; - - var length = longest(Object.keys(types)).length + 1; - var choices = map(types, function(type, key) { + var keys = Object.keys(options.types); + var length = longest(keys).length + 1; + var choices = keys.map(function(key) { return { - name: (key + ':').padEnd(length) + ' ' + type.description, + name: (key + ':').padEnd(length) + ' ' + options.types[key].description, value: key }; }); diff --git a/package-lock.json b/package-lock.json index 03a50710..c87c5218 100644 --- a/package-lock.json +++ b/package-lock.json @@ -12,7 +12,6 @@ "chalk": "^4.1.2", "commitizen": "^4.3.1", "conventional-commit-types": "^3.0.0", - "lodash.map": "^4.6.0", "longest": "^2.0.1", "word-wrap": "^1.2.5" }, diff --git a/package.json b/package.json index b93a8ed9..4997ff07 100644 --- a/package.json +++ b/package.json @@ -24,7 +24,6 @@ "chalk": "^4.1.2", "commitizen": "^4.3.1", "conventional-commit-types": "^3.0.0", - "lodash.map": "^4.6.0", "longest": "^2.0.1", "word-wrap": "^1.2.5" }, From 7edf1ab72562f85c4db61e5edf70f252bec335d9 Mon Sep 17 00:00:00 2001 From: Adam Date: Thu, 18 Sep 2025 19:50:30 +0200 Subject: [PATCH 2/2] remove longest --- engine.js | 15 +++++++++++++-- package-lock.json | 1 - package.json | 1 - 3 files changed, 13 insertions(+), 4 deletions(-) diff --git a/engine.js b/engine.js index 9cdb78ce..59b70eda 100644 --- a/engine.js +++ b/engine.js @@ -1,7 +1,6 @@ 'format cjs'; var wrap = require('word-wrap'); -var longest = require('longest'); var chalk = require('chalk'); var filter = function(array) { @@ -32,12 +31,24 @@ var filterSubject = function(subject, disableSubjectLowerCase) { return subject; }; +/** + * @param input {string[]} + * @return {number} + */ +function getLongestLength(input) { + var longest = Object.keys(input).reduce(function(maxLength, key) { + return Math.max(maxLength, key.length); + }, 0); + + return longest + 1; +} + // This can be any kind of SystemJS compatible module. // We use Commonjs here, but ES6 or AMD would do just // fine. module.exports = function(options) { var keys = Object.keys(options.types); - var length = longest(keys).length + 1; + var length = getLongestLength(keys); var choices = keys.map(function(key) { return { name: (key + ':').padEnd(length) + ' ' + options.types[key].description, diff --git a/package-lock.json b/package-lock.json index c87c5218..dbd798ed 100644 --- a/package-lock.json +++ b/package-lock.json @@ -12,7 +12,6 @@ "chalk": "^4.1.2", "commitizen": "^4.3.1", "conventional-commit-types": "^3.0.0", - "longest": "^2.0.1", "word-wrap": "^1.2.5" }, "devDependencies": { diff --git a/package.json b/package.json index 4997ff07..ea30c6b2 100644 --- a/package.json +++ b/package.json @@ -24,7 +24,6 @@ "chalk": "^4.1.2", "commitizen": "^4.3.1", "conventional-commit-types": "^3.0.0", - "longest": "^2.0.1", "word-wrap": "^1.2.5" }, "devDependencies": {