Skip to content

Commit 65e3fbc

Browse files
committed
Update version string for v2.2.0 final release
Update documentation and contribution guidelines Remove declaration of WRITE_EXTERNAL_STORAGE permission completely (was previously declared for API level <= 18)
1 parent d6310a6 commit 65e3fbc

File tree

6 files changed

+17
-14
lines changed

6 files changed

+17
-14
lines changed

.github/CONTRIBUTING.md

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
GnuCash Android is built by people like you! Please [join us](https://github.com/codinguser/gnucash-android).
22

3-
## Git and Pull requests
3+
## Reporting Issues
4+
* The GitHub issue tracker is used for collecting and managing bugs, feature requests and general development planning.
5+
* When creating a request, first search to make sure a similar one doesn't already exist in the tracker.
6+
* Be as specific as possible when providing descriptions of the problems encountered and what the expected behaviour should be.
7+
* It is also possible to report issues by creating tickets directly from within the app (in the Help Center)
8+
9+
## Code Contributions
410
* Contributions are submitted, reviewed, and accepted using Github pull requests. [Read this article](https://help.github.com/articles/using-pull-requests) for some details. We use the _Fork and Pull_ model, as described there.
511
* You can maintain your stable installation of GnuCash and test with another installation.
612
The two instances of GnuCash Android will live side-by-side on your device and not affect each other. You can install the development version by executing `gradle installDD` inside the root project directory
@@ -18,8 +24,8 @@ The two instances of GnuCash Android will live side-by-side on your device and n
1824
* Try to make clean commits that are easily readable (including descriptive commit messages!)
1925
* Test before you push make sure all test pass on your machine.
2026
* Unit tests can be run with `gradle test`
21-
* UI tests can be run with `gradle cDDAT`
22-
* Make small pull requests that are easy to review but make sure they do add value by themselves.
27+
* UI tests can be run with `gradle spoonDD`. This will run the tests on all connected devices/emulators.
28+
* Make small pull requests that are easy to review but which also add value.
2329

2430
## Coding style
2531
* Do write comments. You don't have to comment every line, but if you come up with something thats a bit complex/weird, just leave a comment. Bear in mind that you will probably leave the project at some point and that other people will read your code. Undocumented huge amounts of code are nearly worthless!

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Change Log
22
===============================================================================
3-
Version 2.2.0 *(2017-05-xx)*
3+
Version 2.2.0 *(2017-05-05)*
44
----------------------------
55
* Feature #646: Option to select backup file using Storage Access Framework
66
* Feature #565: Regular automatic backups (even when not explicitly set by user)

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -88,13 +88,13 @@ Google+ Community: https://plus.google.com/communities/104728406764752407046
8888

8989
There are several ways you could contribute to the development.
9090

91+
* Pull requests are always welcome! You could contribute code by fixing bugs, adding new features or automated tests.
92+
Take a look at the [bug tracker](https://github.com/codinguser/gnucash-android/issues?state=open)
93+
for ideas where to start. Also make sure to read our [contribution guidlines](https://github.com/codinguser/gnucash-android/blob/master/.github/CONTRIBUTING.md)
94+
9195
* One way is providing translations for locales which are not yet available, or improving translations.
9296
Please visit [CrowdIn](https://crowdin.com/project/gnucash-android) in order to update and create new translations
9397

94-
* You could as well contribute code, fixing bugs, new features or automated tests. Pull requests are always welcome.
95-
Take a look at the [bug tracker](https://github.com/codinguser/gnucash-android/issues?state=open)
96-
for ideas where to start. Also take a look at the [contribution guidlines](https://github.com/codinguser/gnucash-android/blob/master/.github/CONTRIBUTING.md)
97-
9898
For development, it is recommended to use the Android Studio for development which is available for free.
9999
Import the project into the IDE using the build.gradle file. The IDE will resolve dependencies automatically.
100100

app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ apply plugin: 'android-apt'
77
def versionMajor = 2
88
def versionMinor = 2
99
def versionPatch = 0
10-
def versionBuild = 3
10+
def versionBuild = 4
1111

1212
def buildTime() {
1313
def df = new SimpleDateFormat("yyyyMMdd HH:mm 'UTC'")

app/src/main/AndroidManifest.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,6 @@
3737
<uses-permission android:label="@string/label_permission_create_accounts"
3838
android:name="org.gnucash.android.permission.CREATE_ACCOUNT" />
3939

40-
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"
41-
android:maxSdkVersion="18" />
4240
<uses-permission android:name="android.permission.VIBRATE"
4341
android:label="Allow device to vibrate with notifications" />
4442
<uses-permission android:name="android.permission.WAKE_LOCK" />

play_store_description.txt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,8 @@ You can also import an existing account hierarchy from GnuCash desktop.
2828

2929
<br/><small>
3030
<i><u>What does the app use the requested permissions for? </u></i>
31-
&bull; READ_EXTERNAL_STORAGE: Used to export transactions/accounts to the SD card
32-
&bull; RECEIVE_BOOT_COMPLETED: Used to restart service for scheduled transactions or exports after device is rebooted
3331
&bull; VIBRATE: Used to provide haptic feedback when entering some inputs
3432
&bull; WAKE_LOCK: Used for keeping device active when exporting scheduled transactions in the background service
35-
&bull; INTERNET/ACCESS_NETWORK_STATE: Used when exporting accounts/transactions to 3rd-party service like Google Drive or DropBox
33+
&bull; RECEIVE_BOOT_COMPLETED: Used to restart service for scheduled transactions or exports after device is rebooted
34+
&bull; INTERNET/ACCESS_NETWORK_STATE: Used when exporting accounts/transactions to 3rd-party service like DropBox or ownCloud
3635
</small>

0 commit comments

Comments
 (0)