Make CI lint checks block on errors

Fix existing rubocop and eslint violations so that lint steps
in the GitHub Actions workflow can run without continue-on-error.
Lint failures now fail the PR check instead of being silently
downgraded to warnings.

REDMINE-21261

Author: tf

.github/workflows/lint.yml

@@ -62,19 +62,10 @@ jobs:
       # Lint
 
       - name: Run RuboCop
-        shell: bash
-        continue-on-error: true
-        run: |
-          bundle exec rubocop --format github | sed 's/::error/::warning/g'
+        run: bundle exec rubocop --format github
 
       - name: Run ESLint in pageflow package
-        shell: bash
-        continue-on-error: true
-        run: |
-          yarn --cwd package lint . --format @jamesacarr/github-actions
+        run: yarn --cwd package lint . --format @jamesacarr/github-actions
 
       - name: Run ESLint in pageflow-scrolled
-        shell: bash
-        continue-on-error: true
-        run: |
-          yarn --cwd entry_types/scrolled/package lint . --format @jamesacarr/github-actions
+        run: yarn --cwd entry_types/scrolled/package lint . --format @jamesacarr/github-actions

admins/pageflow/entry.rb

@@ -318,7 +318,7 @@ def site_policy_scope
       end
 
       # rubocop:todo Metrics/PerceivedComplexity
-      def permitted_attributes # rubocop:todo Metrics/AbcSize
+      def permitted_attributes # rubocop:todo Metrics/AbcSize, Metrics/CyclomaticComplexity
         result = [:title, :type_name, {permalink_attributes: [:slug, :directory_id]}]
         target = if !params[:id] && current_user.admin?
                    Account.first
@@ -331,7 +331,7 @@ def permitted_attributes # rubocop:todo Metrics/AbcSize
         result += permitted_account_attributes
 
         result << :folder_id if create_or_new_action? ||
-                                  (params[:id] && authorized?(:configure_folder_for, resource))
+                                (params[:id] && authorized?(:configure_folder_for, resource))
 
         accounts = if params[:id]
                      resource.account

entry_types/scrolled/lib/pageflow_scrolled/plugin.rb

@@ -1,6 +1,6 @@
 module PageflowScrolled
   # @api private
-  class Plugin < Pageflow::Plugin
+  class Plugin < Pageflow::Plugin # rubocop:disable Metrics/ClassLength
     def configure(config)
       config.features.register('scrolled_entry_type') do |feature_config|
         feature_config.entry_types.register(PageflowScrolled.entry_type)
@@ -71,7 +71,8 @@ def configure(config)
               'section_default_padding_top' => 'max(10em, 20svh)',
               'section_default_padding_bottom' => 'max(10em, 20svh)',
               'content_element_margin_style_default' => '2em',
-              'content_element_box_shadow_style_default' => '0 4px 6px -1px rgb(0 0 0 / 0.2), 0 2px 4px -2px rgb(0 0 0 / 0.15)',
+              'content_element_box_shadow_style_default' =>
+                '0 4px 6px -1px rgb(0 0 0 / 0.2), 0 2px 4px -2px rgb(0 0 0 / 0.15)',
               'box_shadow_clip_margin_bottom' => '3rem',
               'outline_color' => '#a0a0a080'
             },

entry_types/scrolled/package/spec/frontend/inlineEditing/LinkTooltip-spec.js

@@ -247,7 +247,7 @@ describe('LinkTooltip', () => {
       <MainStorylineActivity activeExcursion={activeExcursion}>
         <LinkTooltipProvider>
           <LinkPreview href="https://example.com" openInNewTab={false}>
-            <a>Test Link</a>
+            <a href="https://example.com">Test Link</a>
           </LinkPreview>
         </LinkTooltipProvider>
       </MainStorylineActivity>

entry_types/scrolled/package/spec/frontend/usePrivacyLink-spec.js

@@ -127,10 +127,10 @@ describe('usePrivacyLink', () => {
 
   it('returns props with onClick for javascript: privacy settings url', () => {
     const {result} = renderHookInEntry(
-      // eslint-disable-next-line no-script-url
       () => usePrivacyLink(), {
         seed: {
           legalInfo: {
+            // eslint-disable-next-line no-script-url
             privacy: {url: 'javascript:pageflowDisplayPrivacySettings()'}
           }
         }
@@ -144,10 +144,10 @@ describe('usePrivacyLink', () => {
 
   it('does not append vendors to javascript: privacy settings url', () => {
     const {result} = renderHookInEntry(
-      // eslint-disable-next-line no-script-url
       () => usePrivacyLink({vendors: 'spotify'}), {
         seed: {
           legalInfo: {
+            // eslint-disable-next-line no-script-url
             privacy: {url: 'javascript:pageflowDisplayPrivacySettings()'}
           }
         }

entry_types/scrolled/package/src/frontend/useScrollPositionLifecycle.js

@@ -1,4 +1,4 @@
-import React, {useRef, useEffect, useContext, useMemo, createContext, useState} from 'react';
+import React, {useRef, useEffect, useContext, useMemo, createContext} from 'react';
 import classNames from 'classnames';
 import {useOnScreen} from './useOnScreen';
 import {useDelayedBoolean} from './useDelayedBoolean';

entry_types/scrolled/spec/helpers/pageflow_scrolled/editor/entry_json_seed_helper_spec.rb

@@ -119,7 +119,7 @@ def render(helper, entry)
           pageflow_configure do |config|
             config.for_entry_type(PageflowScrolled.entry_type) do |entry_type_config|
               entry_type_config.consent_vendor_url_matchers = {
-                /\.some-vendor\.com\// => 'someVendor'
+                %r{\.some-vendor\.com/} => 'someVendor'
               }
             end
           end

entry_types/scrolled/spec/pageflow_scrolled/plugin_spec.rb

@@ -42,7 +42,7 @@ def request(uri = 'https://example.com/some-entry')
         pageflow_configure do |config|
           config.for_entry_type(PageflowScrolled.entry_type) do |entry_type_config|
             entry_type_config.consent_vendor_url_matchers = {
-              /\.typeform\.com\// => 'typeform'
+              %r{\.typeform\.com/} => 'typeform'
             }
           end
         end
@@ -62,7 +62,7 @@ def request(uri = 'https://example.com/some-entry')
         pageflow_configure do |config|
           config.for_entry_type(PageflowScrolled.entry_type) do |entry_type_config|
             entry_type_config.consent_vendor_url_matchers = {
-              /\.typeform\.com\// => 'typeform'
+              %r{\.typeform\.com/} => 'typeform'
             }
           end
         end
@@ -82,7 +82,7 @@ def request(uri = 'https://example.com/some-entry')
         pageflow_configure do |config|
           config.for_entry_type(PageflowScrolled.entry_type) do |entry_type_config|
             entry_type_config.consent_vendor_url_matchers = {
-              /google\.com\/maps\/embed/ => 'googleMaps'
+              %r{google\.com/maps/embed} => 'googleMaps'
             }
           end
         end

lib/pageflow/file_types.rb

@@ -35,7 +35,7 @@ def find_by_model!(model)
 
     def with_thumbnail_support
       select do |file_type|
-        file_type.model.instance_methods.include?(:thumbnail_url)
+        file_type.model.method_defined?(:thumbnail_url)
       end
     end
 

package/spec/ui/views/TabsView-spec.js

@@ -1,5 +1,5 @@
 import Backbone from 'backbone';
-import {fireEvent, within} from '@testing-library/dom';
+import {fireEvent} from '@testing-library/dom';
 
 import {TabsView} from 'pageflow/ui';