-
Notifications
You must be signed in to change notification settings - Fork 33
iOS support #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS support #76
Conversation
|
@gregsadetsky is this good to review? Not sure because of the title. |
it is - but I also haven't tested it on Android devices, for instance. would be great to have a little bit more confirmation before merging..? but if it works for you too on iOS, then I'm comfortable with the changes |
|
@gregsadetsky It doesn't works on Android, only it opens up the keyboard and nothing else. InShot_20251202_145505892.mp4 |
|
@bajrangCoder thanks for trying it out and confirming, and sorry obviously. I'll try to run Android emulator (or find a physical phone) and try it out. |
It's okay, btw for selection on Android you'll need to implement custom stuffs. |
|
@gregsadetsky if you confirm that this preserves 100% of the desktop functionality I'm good to merge. iPhone without Android is better than no mobile support at all. |
|
smart&agreed. let me give it a final spin across a few browsers and give you the final thumbs up (& resolve the conflict) |
|
Sweet. Update the title when you get a shot too so it indicates this is just iOS support. |
Focus textarea on touch/click to trigger mobile keyboard. Use clip-path to hide iOS caret.
6f62e6c to
09de762
Compare
Resize terminal when mobile keyboard shows/hides using visualViewport API.
|
@kylecarbs looking good here, tested the desktop version on Chrome/Safari/Firefox on my Mac, and on iOS It's also deployed to https://ghostty.ondis.co/ right now I think we're good for a merge! Thank you |
works here locally on my iPhone, would be great if more folks could try it out!
#74 would also be great to have merged (I patched it locally) as it makes running ngrok a lot simpler to test this on real devices :-)
cheers! thanks