Skip to content

Conversation

@gregsadetsky
Copy link
Contributor

works here locally on my iPhone, would be great if more folks could try it out!

#74 would also be great to have merged (I patched it locally) as it makes running ngrok a lot simpler to test this on real devices :-)

cheers! thanks

@kylecarbs
Copy link
Member

@gregsadetsky is this good to review? Not sure because of the title.

@gregsadetsky gregsadetsky changed the title WIP mobile support Mobile support Dec 2, 2025
@gregsadetsky
Copy link
Contributor Author

@gregsadetsky is this good to review? Not sure because of the title.

it is - but I also haven't tested it on Android devices, for instance. would be great to have a little bit more confirmation before merging..?

but if it works for you too on iOS, then I'm comfortable with the changes

@bajrangCoder
Copy link

bajrangCoder commented Dec 2, 2025

@gregsadetsky It doesn't works on Android, only it opens up the keyboard and nothing else.

InShot_20251202_145505892.mp4

@gregsadetsky
Copy link
Contributor Author

@bajrangCoder thanks for trying it out and confirming, and sorry obviously. I'll try to run Android emulator (or find a physical phone) and try it out.

@bajrangCoder
Copy link

@bajrangCoder thanks for trying it out and confirming, and sorry obviously. I'll try to run Android emulator (or find a physical phone) and try it out.

It's okay, btw for selection on Android you'll need to implement custom stuffs.
As in one of my app where i used xtermjs for terminal stuff for Android, I had implemented custom touch selection stuffs which mimics browser default behaviour.

@kylecarbs
Copy link
Member

@gregsadetsky if you confirm that this preserves 100% of the desktop functionality I'm good to merge. iPhone without Android is better than no mobile support at all.

@gregsadetsky
Copy link
Contributor Author

smart&agreed. let me give it a final spin across a few browsers and give you the final thumbs up (& resolve the conflict)

@kylecarbs
Copy link
Member

Sweet. Update the title when you get a shot too so it indicates this is just iOS support.

Focus textarea on touch/click to trigger mobile keyboard.
Use clip-path to hide iOS caret.
@gregsadetsky gregsadetsky force-pushed the mobile-keyboard-support branch from 6f62e6c to 09de762 Compare December 3, 2025 19:20
Resize terminal when mobile keyboard shows/hides using visualViewport API.
@gregsadetsky gregsadetsky changed the title Mobile support iOS support Dec 3, 2025
@gregsadetsky
Copy link
Contributor Author

@kylecarbs looking good here, tested the desktop version on Chrome/Safari/Firefox on my Mac, and on iOS

It's also deployed to https://ghostty.ondis.co/ right now

I think we're good for a merge! Thank you

@kylecarbs kylecarbs merged commit 59bb045 into coder:main Dec 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants