Fixed array access

Author: shai-almog

scripts/run-android-instrumentation-tests.sh

@@ -137,7 +137,7 @@ fi
 # ---- Chunk accounting (diagnostics) ---------------------------------------
 
 XML_CHUNKS_TOTAL=0
-for x in "${XMLS[@]:-}"; do
+for x in "${XMLS[@]}"; do
   c="$(count_chunks "$x")"; c="${c//[^0-9]/}"; : "${c:=0}"
   XML_CHUNKS_TOTAL=$(( XML_CHUNKS_TOTAL + c ))
 done
@@ -161,8 +161,8 @@ fi
 : > "$SCREENSHOT_OUT"
 SOURCE=""
 
-if [ "${#XMLS[@]:-0}" -gt 0 ] && [ "${XML_CHUNKS_TOTAL:-0}" -gt 0 ]; then
-  for x in "${XMLS[@]:-}"; do
+if [ "${#XMLS[@]}" -gt 0 ] && [ "${XML_CHUNKS_TOTAL:-0}" -gt 0 ]; then
+  for x in "${XMLS[@]}"; do
     c="$(count_chunks "$x")"; c="${c//[^0-9]/}"; : "${c:=0}"
     [ "$c" -gt 0 ] || continue
     ra_log "Reassembling from XML: $x (chunks=$c)"
@@ -197,7 +197,7 @@ if [ -z "$SOURCE" ]; then
     if [ "${LOGCAT_CHUNKS:-0}" -gt 0 ]; then extract_cn1ss_stream "$LOGCAT_FILE"; fi
     if [ "${XML_CHUNKS_TOTAL:-0}" -gt 0 ] && [ "${LOGCAT_CHUNKS:-0}" -eq 0 ]; then
       # concatenate all XMLs
-      for x in "${XMLS[@]:-}"; do
+      for x in "${XMLS[@]}"; do
         if [ "$(count_chunks "$x")" -gt 0 ]; then extract_cn1ss_stream "$x"; fi
       done
     fi
@@ -225,7 +225,7 @@ ra_log "SUCCESS -> screenshot saved (${SOURCE}), size: $(stat -c '%s' "$SCREENSH
 
 # Copy useful artifacts for GH Actions
 cp -f "$LOGCAT_FILE" "$ARTIFACTS_DIR/$(basename "$LOGCAT_FILE")" 2>/dev/null || true
-for x in "${XMLS[@]:-}"; do
+for x in "${XMLS[@]}"; do
   cp -f "$x" "$ARTIFACTS_DIR/$(basename "$x")" 2>/dev/null || true
 done
 [ -n "${TEST_EXEC_LOG:-}" ] && cp -f "$TEST_EXEC_LOG" "$ARTIFACTS_DIR/test-results.log" 2>/dev/null || true