bug(cli): preserve base64 padding in environment variable parsing (#882)

## What

## Why

## Notes

---------

Co-authored-by: Prabesh <[email protected]>

Author: vadim-kharin-codefresh

lib/interface/cli/helpers/general.js

@@ -94,9 +94,12 @@ const prepareKeyValueObjectsFromCLIEnvOption = (environmentVariables) => {
     const envArray = _.isArray(environmentVariables) ? environmentVariables : [environmentVariables];
 
     envArray.forEach((vars) => {
-        const fields = vars.split('=');
-        const key = fields[0];
-        const value = fields[1];
+        const index = vars.indexOf('=');
+        if (index === -1) {
+            throw new CFError('Invalid environment variable format. please enter [key]=[value]');
+        }
+        const key = vars.substring(0, index);
+        const value = vars.substring(index + 1);
         if (_.isUndefined(key) || _.isUndefined(value)) {
             throw new CFError('Invalid environment variable format. please enter [key]=[value]');
         }

lib/interface/cli/helpers/helpers.unit.spec.js

@@ -1,6 +1,8 @@
 const _ = require('lodash');
+const CFError = require('cf-errors');
 const helper = require('./image');
 const { createEntity, entityList } = require('./entitiesManifests');
+const { prepareKeyValueObjectsFromCLIEnvOption } = require('./general');
 
 const { extractImages } = helper;
 
@@ -32,6 +34,43 @@ describe('helpers unit tests', () => {
         }
     });
 
+    describe('general', () => {
+        describe('prepareKeyValueObjectsFromCLIEnvOption', () => {
+            it('should parse key value object from array', () => {
+                const result = prepareKeyValueObjectsFromCLIEnvOption([
+                    'SECRET_PASS=YWJjZA===',
+                    'USERNAME=testUserName',
+                ]);
+                expect(result).toEqual([
+                    {
+                        key: 'SECRET_PASS',
+                        value: 'YWJjZA===',
+                    },
+                    {
+                        key: 'USERNAME',
+                        value: 'testUserName',
+                    },
+                ]);
+            });
+
+            it('should parse key value object from string', () => {
+                const result = prepareKeyValueObjectsFromCLIEnvOption('TEST=testData');
+                expect(result).toEqual([
+                    {
+                        key: 'TEST',
+                        value: 'testData',
+                    },
+                ]);
+            });
+
+            it('should throw error when add incorrect environment variable', () => {
+                expect(
+                    () => prepareKeyValueObjectsFromCLIEnvOption('TEST'),
+                ).toThrow(new CFError('Invalid environment variable format. please enter [key]=[value]'));
+            });
+        });
+    });
+
     describe('images', () => {
         describe('#extractImages', () => {
             beforeAll(() => {
@@ -93,10 +132,10 @@ describe('helpers unit tests', () => {
                     },
                 ];
                 const extracted = extractImages(images);
-                const extractedDates = _.map(extracted, i => i.info.created);
+                const extractedDates = _.map(extracted, (i) => i.info.created);
                 const initialSortedDates = _.chain(images)
                     .orderBy(['created'], ['desc'])
-                    .map(i => i.created)
+                    .map((i) => i.created)
                     .value();
                 expect(extractedDates).toEqual(initialSortedDates);
             });

package.json

@@ -1,6 +1,6 @@
 {
   "name": "codefresh",
-  "version": "0.89.0",
+  "version": "0.89.1",
   "description": "Codefresh command line utility",
   "main": "index.js",
   "preferGlobal": true,