Feature l11 (#39)

StanBarrows · web-flow · commit 6c1c3c1fb279 · 2025-02-27T21:10:58.000+07:00
diff --git a/.github/workflows/dependency-review.yml b/.github/workflows/dependency-review.yml
@@ -17,4 +17,4 @@ jobs:
       - name: 'Checkout Repository'
         uses: actions/checkout@v3
       - name: 'Dependency Review'
-        uses: actions/dependency-review-action@v3
+        uses: actions/dependency-review-action@v4
diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
@@ -15,11 +15,8 @@ jobs:
       matrix:
         os: [ ubuntu-latest, windows-latest ]
         php: [ 8.2, 8.3 ]
-        laravel: [ 10.* ]
+        laravel: [ 11.* ]
         stability: [ prefer-lowest, prefer-stable ]
-        include:
-          - laravel: 10.*
-            testbench: 8.*
 
     name: P${{ matrix.php }} - L${{ matrix.laravel }} - ${{ matrix.stability }} - ${{ matrix.os }}
 
@@ -41,7 +38,7 @@ jobs:
 
       - name: Install dependencies
         run: |
-          composer require "laravel/framework:${{ matrix.laravel }}" "orchestra/testbench:${{ matrix.testbench }}" --no-interaction --no-update
+          composer require "laravel/framework:${{ matrix.laravel }}" --no-interaction --no-update
           composer update --${{ matrix.stability }} --prefer-dist --no-interaction
 
       - name: Set phpunit.xml
@@ -55,7 +52,7 @@ jobs:
           ZAMMAD_OBJECT_REFERENCE_ERROR_IGNORE: true
 
       - name: Store test reports
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
           name: Store report
           retention-days: 1
diff --git a/composer.json b/composer.json
@@ -22,21 +22,21 @@
         }
     ],
     "require": {
-        "php": "^8.2",
-        "guzzlehttp/guzzle": "^7.8.1",
-        "illuminate/contracts": "^10.0",
+        "php": ">=8.2",
+        "guzzlehttp/guzzle": "^7.8",
+        "illuminate/contracts": "^11.0",
         "spatie/laravel-package-tools": "^1.16",
-        "saloonphp/laravel-plugin": "^3.3",
-        "saloonphp/saloon": "^3.6"
+        "saloonphp/laravel-plugin": "^3.5",
+        "saloonphp/saloon": "^3.7"
     },
     "require-dev": {
         "laravel/pint": "^1.13",
-        "nunomaduro/collision": "^7.10",
-        "nunomaduro/larastan": "^2.8",
+        "nunomaduro/collision": "^8.1",
+        "larastan/larastan": "^2.9",
         "pestphp/pest": "^2.3",
-        "orchestra/testbench": "^8.20",
+        "orchestra/testbench": "^9.0",
         "pestphp/pest-plugin-laravel": "^2.2",
-        "pestphp/pest-plugin-arch": "^2.6",
+        "pestphp/pest-plugin-arch": "^2.7",
         "phpstan/extension-installer": "^1.3",
         "phpstan/phpstan-deprecation-rules": "^1.1",
         "phpstan/phpstan-phpunit": "^1.3",
diff --git a/src/Classes/RequestClass.php b/src/Classes/RequestClass.php
@@ -30,7 +30,7 @@ public function __construct()
         $this->ignoreReferenceErrorIngore = config('zammad.object_reference_error_ignore');
         $this->objectHasReferenceError = config('zammad.objet_reference_error');
 
-        $this->connector = new ZammadConnector();
+        $this->connector = new ZammadConnector;
     }
 
     private function performRequest(Request $request): Response
diff --git a/src/DTO/Attachment.php b/src/DTO/Attachment.php
@@ -28,8 +28,7 @@ public function __construct(
         public int $size,
         public string $name,
         public string $type,
-    ) {
-    }
+    ) {}
 
     public function url(): string
     {
diff --git a/src/DTO/Comment.php b/src/DTO/Comment.php
@@ -89,8 +89,7 @@ public function __construct(
         public Collection $attachments,
         public Carbon $updated_at,
         public Carbon $created_at,
-    ) {
-    }
+    ) {}
 
     public static function fake(
         ?int $id = null,
diff --git a/src/DTO/ObjectAttribute.php b/src/DTO/ObjectAttribute.php
@@ -31,8 +31,7 @@ public function __construct(
         public int $position,
         public array $data_option,
         public ?array $data_option_new,
-    ) {
-    }
+    ) {}
 
     public static function fake(
         ?int $id = null,
diff --git a/src/DTO/User.php b/src/DTO/User.php
@@ -31,8 +31,7 @@ public function __construct(
         public Carbon $updated_at,
         public Carbon $created_at,
         public ?array $expanded = null,
-    ) {
-    }
+    ) {}
 
     public static function fake(
         ?int $id = null,
diff --git a/src/Events/ZammadResponseLog.php b/src/Events/ZammadResponseLog.php
@@ -13,7 +13,5 @@ class ZammadResponseLog
     use InteractsWithSockets;
     use SerializesModels;
 
-    public function __construct(public Response $response)
-    {
-    }
+    public function __construct(public Response $response) {}
 }
diff --git a/src/Requests/AccessTokens/CreateAccessTokenRequest.php b/src/Requests/AccessTokens/CreateAccessTokenRequest.php
@@ -15,8 +15,7 @@ class CreateAccessTokenRequest extends Request implements HasBody
 
     public function __construct(
         protected array $payload
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/AccessTokens/DestroyAccessTokenRequest.php b/src/Requests/AccessTokens/DestroyAccessTokenRequest.php
@@ -12,8 +12,7 @@ class DestroyAccessTokenRequest extends Request
     public function __construct(
         public int $id,
         public bool $expand = false
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/Attachment/GetAttachmentRequest.php b/src/Requests/Attachment/GetAttachmentRequest.php
@@ -13,8 +13,7 @@ public function __construct(
         public int $ticketId,
         public int $commentId,
         public int $attachmentId,
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/Comments/CreateCommentRequest.php b/src/Requests/Comments/CreateCommentRequest.php
@@ -17,8 +17,7 @@ class CreateCommentRequest extends Request implements HasBody
 
     public function __construct(
         protected array $payload
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/Comments/DestroyCommentRequest.php b/src/Requests/Comments/DestroyCommentRequest.php
@@ -11,8 +11,7 @@ class DestroyCommentRequest extends Request
 
     public function __construct(
         public int $id
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/Comments/GetCommentByTicketRequest.php b/src/Requests/Comments/GetCommentByTicketRequest.php
@@ -11,8 +11,7 @@ class GetCommentByTicketRequest extends Request
 
     public function __construct(
         public int $id
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/Comments/GetCommentRequest.php b/src/Requests/Comments/GetCommentRequest.php
@@ -13,8 +13,7 @@ class GetCommentRequest extends Request
 
     public function __construct(
         public int $id
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/ObjectAttribute/CreateObjectAttributeRequest.php b/src/Requests/ObjectAttribute/CreateObjectAttributeRequest.php
@@ -17,8 +17,7 @@ class CreateObjectAttributeRequest extends Request implements HasBody
 
     public function __construct(
         protected array $payload
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/ObjectAttribute/DestroyObjectAttributeRequest.php b/src/Requests/ObjectAttribute/DestroyObjectAttributeRequest.php
@@ -11,8 +11,7 @@ class DestroyObjectAttributeRequest extends Request
 
     public function __construct(
         public int $id
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/ObjectAttribute/GetObjectAttributeRequest.php b/src/Requests/ObjectAttribute/GetObjectAttributeRequest.php
@@ -13,8 +13,7 @@ class GetObjectAttributeRequest extends Request
 
     public function __construct(
         public int $id
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/ObjectAttribute/UpdateObjectAttributeRequest.php b/src/Requests/ObjectAttribute/UpdateObjectAttributeRequest.php
@@ -18,8 +18,7 @@ class UpdateObjectAttributeRequest extends Request implements HasBody
     public function __construct(
         public int $id,
         public array $payload
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/Tickets/AllTicketsRequest.php b/src/Requests/Tickets/AllTicketsRequest.php
@@ -12,8 +12,7 @@ class AllTicketsRequest extends Request
     public function __construct(
         public ?int $perPage = null,
         public ?int $page = null,
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/Tickets/CreateTicketRequest.php b/src/Requests/Tickets/CreateTicketRequest.php
@@ -18,8 +18,7 @@ class CreateTicketRequest extends Request implements HasBody
     public function __construct(
         protected array $payload,
         public bool $expand = false
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/Tickets/DestroyTicketRequest.php b/src/Requests/Tickets/DestroyTicketRequest.php
@@ -11,8 +11,7 @@ class DestroyTicketRequest extends Request
 
     public function __construct(
         public int $id
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/Tickets/GetTicketRequest.php b/src/Requests/Tickets/GetTicketRequest.php
@@ -14,8 +14,7 @@ class GetTicketRequest extends Request
     public function __construct(
         public int $id,
         public bool $expand = false
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/Tickets/SearchTicketRequest.php b/src/Requests/Tickets/SearchTicketRequest.php
@@ -14,8 +14,7 @@ public function __construct(
         public ?int $limit = null,
         public ?int $perPage = null,
         public ?int $page = null,
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/Users/AllUsersRequest.php b/src/Requests/Users/AllUsersRequest.php
@@ -12,8 +12,7 @@ class AllUsersRequest extends Request
     public function __construct(
         public ?int $perPage = null,
         public ?int $page = null,
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/Users/CreateUserRequest.php b/src/Requests/Users/CreateUserRequest.php
@@ -18,8 +18,7 @@ class CreateUserRequest extends Request implements HasBody
     public function __construct(
         protected array $payload,
         public bool $expand = false
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/Users/DestroyUserRequest.php b/src/Requests/Users/DestroyUserRequest.php
@@ -11,8 +11,7 @@ class DestroyUserRequest extends Request
 
     public function __construct(
         public int $id
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/Users/GetUserRequest.php b/src/Requests/Users/GetUserRequest.php
@@ -14,8 +14,7 @@ class GetUserRequest extends Request
     public function __construct(
         public ?int $id = null,
         public bool $expand = false
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/Users/SearchUserRequest.php b/src/Requests/Users/SearchUserRequest.php
@@ -12,8 +12,7 @@ class SearchUserRequest extends Request
     public function __construct(
         public string $term,
         public ?int $limit = null,
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/Users/UpdateUserRequest.php b/src/Requests/Users/UpdateUserRequest.php
@@ -19,8 +19,7 @@ public function __construct(
         public int $id,
         public array $payload,
         public bool $expand = false
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Zammad.php b/src/Zammad.php
@@ -13,31 +13,31 @@ class Zammad
 {
     public function user(): UserResource
     {
-        return new UserResource();
+        return new UserResource;
     }
 
     public function userAccessToken(): UserAccessToken
     {
-        return new UserAccessToken();
+        return new UserAccessToken;
     }
 
     public function ticket(): TicketResource
     {
-        return new TicketResource();
+        return new TicketResource;
     }
 
     public function comment(): CommentResource
     {
-        return new CommentResource();
+        return new CommentResource;
     }
 
     public function attachment(): AttachmentResource
     {
-        return new AttachmentResource();
+        return new AttachmentResource;
     }
 
     public function object(): ObjectAttributeResource
     {
-        return new ObjectAttributeResource();
+        return new ObjectAttributeResource;
     }
 }
diff --git a/tests/Feature/AttachmentResourceTest.php b/tests/Feature/AttachmentResourceTest.php
@@ -5,7 +5,7 @@
 use Illuminate\Support\Facades\Event;
 
 it('can download an attachment', function () {
-    $content = (new Zammad())->attachment()->download(
+    $content = (new Zammad)->attachment()->download(
         ticketId: 32,
         commentId: 111,
         attachmentId: 42,
diff --git a/tests/Feature/CommentResourceTest.php b/tests/Feature/CommentResourceTest.php
diff --git a/tests/Feature/ObjectAttributeResourceTest.php b/tests/Feature/ObjectAttributeResourceTest.php
diff --git a/tests/Feature/TicketResourceTest.php b/tests/Feature/TicketResourceTest.php
diff --git a/tests/Feature/UserAccessTokenRequestTest.php b/tests/Feature/UserAccessTokenRequestTest.php
diff --git a/tests/Feature/UserResourceTest.php b/tests/Feature/UserResourceTest.php
diff --git a/tests/Feature/ZammadConnectorTest.php b/tests/Feature/ZammadConnectorTest.php

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ public function __construct()`
`30`	`30`	`$this->ignoreReferenceErrorIngore = config('zammad.object_reference_error_ignore');`
`31`	`31`	`$this->objectHasReferenceError = config('zammad.objet_reference_error');`
`32`	`32`
`33`		`- $this->connector = new ZammadConnector();`
	`33`	`+ $this->connector = new ZammadConnector;`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`private function performRequest(Request $request): Response`
Original file line number	Diff line number	Diff line change
`@@ -28,8 +28,7 @@ public function __construct(`
`28`	`28`	`public int $size,`
`29`	`29`	`public string $name,`
`30`	`30`	`public string $type,`
`31`		`- ) {`
`32`		`- }`
	`31`	`+ ) {}`
`33`	`32`
`34`	`33`	`public function url(): string`
`35`	`34`	`{`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,5 @@ class ZammadResponseLog`
`13`	`13`	`use InteractsWithSockets;`
`14`	`14`	`use SerializesModels;`
`15`	`15`
`16`		`- public function __construct(public Response $response)`
`17`		`- {`
`18`		`- }`
	`16`	`+ public function __construct(public Response $response) {}`
`19`	`17`	`}`
Original file line number	Diff line number	Diff line change
`@@ -15,8 +15,7 @@ class CreateAccessTokenRequest extends Request implements HasBody`
`15`	`15`
`16`	`16`	`public function __construct(`
`17`	`17`	`protected array $payload`
`18`		`- ) {`
`19`		`- }`
	`18`	`+ ) {}`
`20`	`19`
`21`	`20`	`public function resolveEndpoint(): string`
`22`	`21`	`{`