From 8a1a3d28945f24b0ecf7984f4e20d72a5903e88b Mon Sep 17 00:00:00 2001 From: leda Date: Wed, 11 Jul 2018 23:14:18 +0800 Subject: [PATCH 1/2] adapt toggle node remove logic --- .../packages/creator-luacpp-support/core/parser/Toggle.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/creator_project/packages/creator-luacpp-support/core/parser/Toggle.js b/creator_project/packages/creator-luacpp-support/core/parser/Toggle.js index 704a2569..5d81359e 100644 --- a/creator_project/packages/creator-luacpp-support/core/parser/Toggle.js +++ b/creator_project/packages/creator-luacpp-support/core/parser/Toggle.js @@ -42,6 +42,9 @@ class Toggle extends Node { } // remove Background and CheckMark + // on creator 1.9.x, checkmark and background is brother node, so we need remove both + Utils.remove_child_by_id(this, checkmark_component.node.__id__); + // on oldder version, checkmark is the child node of background, so only remove parent is ok Utils.remove_child_by_id(this, background_node_id); // 2nd: parse children From 840a205825669fd6249b9b288ea30556c3d5198e Mon Sep 17 00:00:00 2001 From: leda Date: Wed, 11 Jul 2018 23:22:59 +0800 Subject: [PATCH 2/2] fix typo --- .../packages/creator-luacpp-support/core/parser/Toggle.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/creator_project/packages/creator-luacpp-support/core/parser/Toggle.js b/creator_project/packages/creator-luacpp-support/core/parser/Toggle.js index 5d81359e..c1a5ce74 100644 --- a/creator_project/packages/creator-luacpp-support/core/parser/Toggle.js +++ b/creator_project/packages/creator-luacpp-support/core/parser/Toggle.js @@ -44,7 +44,7 @@ class Toggle extends Node { // remove Background and CheckMark // on creator 1.9.x, checkmark and background is brother node, so we need remove both Utils.remove_child_by_id(this, checkmark_component.node.__id__); - // on oldder version, checkmark is the child node of background, so only remove parent is ok + // on older version, checkmark is the child node of background, so only remove parent is ok Utils.remove_child_by_id(this, background_node_id); // 2nd: parse children