-
Notifications
You must be signed in to change notification settings - Fork 478
Archive v2.1 documentation #21195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Archive v2.1 documentation #21195
Conversation
- Delete v2.1 directory and images - Remove sidebar-data-v2.1.json to disable sidebar navigation - Delete _includes/v2.1/ and _includes/releases/v2.1/ directories - Update releases/v2.1.md to archived format with support policy links - Add all 27 v2.1 release anchors to prevent broken links from unsupported-versions page - Fix 78+ cross-version references pointing to v2.1: - Replace v2.1 include references with inline content in v2.0 tutorials - Move DBeaver and Kubernetes images to images/common/ directory - Update all IntelliJ image references to use images/common/intellij/ - Replace v2.1 URLs with stable docs links - Archive follows v19.2 pattern: page exists but shows archived notice - htmltest passes 100% with all 9,369 documents tested
Only archive v2.1 documentation, keep Gemfile unchanged
Files changed:
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
…est config The sidebar_htmltest.rb plugin was generating HTML test files for all versions, including those marked as ignored in .htmltest.yml. This caused htmltest failures for archived versions that have sidebar-data files but include CockroachCloud links that don't exist. Changes: - Read .htmltest.yml to identify ignored version directories - Skip generating sidebar HTML test files for ignored versions - Add logging to show which versions are being skipped This ensures that only versions actually tested by htmltest have corresponding sidebar test files generated.
rmloveland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great overall! We're very close, please:
- Remove the LLM-generated script that hacks some SSL settings
- Remove the newly introduced cross-version links in some of the later versions
- Add the zip archive of v2.1 to the 'Archived Documentation' page - right now it's missing. Although if you prefer to do that in another PR that also works
- Remove LLM-generated openssl_fix.rb script - Fix DBeaver tutorial image links in v20.2, v21.1, and v21.2 - Fix locality-aware backup image link in v22.2 - Add missing locality-aware-backups.png to v22.2 images directory Addresses code review feedback about newly introduced cross-version links that incorrectly referenced v23.1 images from older version documentation.
- Remove LLM-generated openssl_fix.rb script - Remove debug files (error.log, output.txt) - Update sidebar_htmltest.rb to respect htmltest config and skip archived versions This addresses issues similar to those found in PR #21195 for v2.1: - Removes SSL workaround script that doesn't belong in src/current - Removes accidentally committed build artifacts - Ensures htmltest skips archived versions during validation
- Copy DBeaver and IntelliJ images from v2.1 to v20.1 directory - Update image links in dbeaver.md and intellij-idea.md to use v20.1 images - Update sidebar_htmltest.rb to respect htmltest config and skip archived versions Addresses cross-version linking issues similar to those fixed in PR #21195
rmloveland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Eeshan!
Summary
Archives CockroachDB v2.1 documentation following the established v19.2 pattern. This removes
outdated documentation while preserving the release page with proper archived notice and
support policy links.
Changes Made
🗂️ Core Archival
/v2.1/folder with allversion-specific docs
/images/v2.1/directorysidebar-data-v2.1.jsonto disable sidebar onarchived page
_includes/v2.1/and_includes/releases/v2.1/directories
🔗 Cross-Version Reference Fixes (78+ references)
{% include v2.1/client-transaction-retry.md %}with inline transaction retry content
images/common/directoriesuse common directory
docs.cockroachlabs.com/docs/v2.1/links to point tostable docs
version
📄 Release Page Updates
releases/v2.1.mdfrom dynamic content to staticarchived notice
#v2-1-0through#v2-1-11, plus alpha/beta/RC variants) to prevent broken links from unsupported-versionspage
Validation
navigation
Impact
downloads