Project Copacetic General Technical Review #1941
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leonard Wang <[email protected]>
|
This is fantastic! The tech review is not mandatory though really helps during review. |
|
Thanks for clarifying! We were following this guidance - https://github.com/cncf/toc/blob/main/operations/toc-templates/template-dd-pr-incubation.md - which put it as a required step. In that case, do we submit another PR following this template here for an official incubation application? - https://github.com/cncf/toc/blob/main/operations/toc-templates/template-dd-pr-incubation.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project Copacetic (sandbox) is applying for incubation, and verified with the TAG contact that the general technical review is a prerequisite to the incubation application process. This PR fills out the appropiate sections of the offline General Technical Review Template applicable for a Sandbox -> Incubation Project.