Fix base64 encoding for ocm-container CLI compatibility (#139)

* Fix base64 encoding to use standard alphabet for CLI compatibility

Switch ALERT_DETAILS encoding from RawURLEncoding to RawStdEncoding.
RawURLEncoding uses a URL-safe alphabet (-_) that the `base64 -d`
CLI tool inside ocm-container doesn't understand. RawStdEncoding uses
the standard alphabet (+/) which is compatible with `base64 -d`, while
still avoiding = padding that breaks ocm-container's env var parsing.

Created with assistance from Claude 🤖 <claude@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Christopher Collins <collins.christopher@gmail.com>

* Fix pre-existing lint issues

- main.go: suppress errcheck for deferred asyncWriter.Close()
- model_test.go: suppress staticcheck SA9003 for placeholder empty branch
- views.go: remove unused renderActionLogHeader function

Created with assistance from Claude 🤖 <claude@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Christopher Collins <collins.christopher@gmail.com>

* Address Copilot review feedback

- Fix inconsistent base64 encoding references in README
- Remove empty if block in model_test.go

Created with assistance from Claude 🤖 <claude@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Christopher Collins <collins.christopher@gmail.com>

---------

Signed-off-by: Christopher Collins <collins.christopher@gmail.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: clcollins

README.md

@@ -229,15 +229,15 @@ When using `ocm-container` as your cluster login command, srepd automatically pa
 The following environment variables are automatically set:
 
 * `PAGERDUTY_INCIDENT` - The PagerDuty incident ID
-* `ALERT_DETAILS` - Base64 URL-encoded JSON containing the full incident object, all associated alerts, and incident notes
+* `ALERT_DETAILS` - Base64-encoded JSON containing the full incident object, all associated alerts, and incident notes
 
 Example usage inside ocm-container:
 
 ```bash
 # View the incident ID
 echo $PAGERDUTY_INCIDENT
 
-# Decode and view the full alert details (note: using base64 -d with URL encoding)
+# Decode and view the full alert details
 echo $ALERT_DETAILS | base64 -d | jq .
 
 # Extract specific alert information
@@ -247,6 +247,6 @@ echo $ALERT_DETAILS | base64 -d | jq '.alerts[0].body.details.cluster_id'
 echo $ALERT_DETAILS | base64 -d | jq '.notes'
 ```
 
-**Note:** The `ALERT_DETAILS` variable uses base64 URL encoding (RFC 4648) without padding to avoid parsing issues with `=` characters.
+**Note:** The `ALERT_DETAILS` variable uses standard base64 encoding without padding to avoid parsing issues with `=` characters in ocm-container's env var handling.
 
 These environment variables are automatically added when you use the login feature (press `l` on an incident). No additional configuration is required.

main.go

@@ -44,7 +44,7 @@ func main() {
 
 	// Use async writer to prevent log I/O from blocking the UI
 	asyncWriter := newAsyncWriter(f, 1000) // Buffer up to 1000 log messages
-	defer asyncWriter.Close()
+	defer asyncWriter.Close() //nolint:errcheck
 
 	log.SetOutput(asyncWriter)
 

pkg/tui/commands.go

@@ -448,9 +448,10 @@ func login(vars map[string]string, launcher launcher.ClusterLauncher, incident *
 		if err != nil {
 			log.Warn("tui.login(): failed to marshal alert data", "error", err)
 		} else {
-			// Use RawURLEncoding which doesn't add padding (no = characters)
-			// This avoids issues with ocm-container's env var parsing which splits on =
-			encoded := base64.RawURLEncoding.EncodeToString(jsonData)
+			// Use RawStdEncoding: standard base64 alphabet (+/) without padding (no = characters)
+			// No padding avoids issues with ocm-container's env var parsing which splits on =
+			// Standard alphabet ensures `echo $ALERT_DETAILS | base64 -d` works in the container
+			encoded := base64.RawStdEncoding.EncodeToString(jsonData)
 			envFlags = append(envFlags, "-e", fmt.Sprintf("ALERT_DETAILS=%s", encoded))
 		}
 	}

pkg/tui/commands_test.go

@@ -458,14 +458,14 @@ func TestLoginEnvironmentVariables(t *testing.T) {
 			assert.NoError(t, err, "Failed to marshal alertData")
 			assert.NotNil(t, jsonData, "JSON data should not be nil")
 
-			// Test that it can be base64 URL encoded (without padding)
-			encoded := base64.RawURLEncoding.EncodeToString(jsonData)
+			// Test that it can be base64 encoded (standard alphabet, without padding)
+			encoded := base64.RawStdEncoding.EncodeToString(jsonData)
 			assert.NotEmpty(t, encoded, "Base64 encoding should not be empty")
 			// Verify no padding characters
-			assert.NotContains(t, encoded, "=", "RawURLEncoding should not contain = padding")
+			assert.NotContains(t, encoded, "=", "RawStdEncoding should not contain = padding")
 
 			// Test that it can be decoded back
-			decoded, err := base64.RawURLEncoding.DecodeString(encoded)
+			decoded, err := base64.RawStdEncoding.DecodeString(encoded)
 			assert.NoError(t, err, "Failed to decode base64")
 
 			var decodedData alertData

pkg/tui/model_test.go

@@ -266,14 +266,6 @@ func TestGetHighlightedIncident(t *testing.T) {
 			m := createTestModel()
 			m.incidentList = tt.incidentList
 
-			// Set up table rows to match incident list
-			if tt.hasSelectedRow && len(tt.incidentList) > 0 {
-				// Manually set the cursor to simulate a selected row
-				// We'll use the test directly by creating a mock selected row
-				// Since we can't easily mock the table.SelectedRow(), we'll test by
-				// setting up the incident list and verifying the lookup logic
-			}
-
 			// For this test, we'll directly test the lookup logic
 			// by simulating what getHighlightedIncident does
 			var result *pagerduty.Incident

pkg/tui/views.go

@@ -252,17 +252,6 @@ func (m model) renderHeader() string {
 	return s.String()
 }
 
-func (m model) renderActionLogHeader() string {
-	headerText := "Action Log"
-	// Center the header text horizontally
-	// Using windowSize.Width and paddedStyle to match the main UI width
-	centeredHeader := lipgloss.NewStyle().
-		Width(windowSize.Width).
-		Align(lipgloss.Center).
-		Render(headerText)
-	return paddedStyle.Render(centeredHeader)
-}
-
 func (m model) renderBottomStatus() string {
 	var s strings.Builder
 	var selectedID string