Merge pull request #312 from meastham/meastham/fix_close_race

Fix connection_wrapper destructor sometimes closing other connections

Author: auxten

AUTHORS.md

@@ -1,6 +1,18 @@
 # Contributors
 
 * auxten [[email protected]](mailto:[email protected])
+* Daniel Robbins  [[email protected]](mailto:[email protected])
+* Lorenzo Mangani  [[email protected]](mailto:[email protected])
+* nmreadelf  [[email protected]](mailto:[email protected])
+* laodouya  [[email protected]](mailto:[email protected])
+* DemoYeti  [[email protected]](mailto:[email protected])
+* Michael Razuvaev  [[email protected]](mailto:[email protected])
+* Nevin  [[email protected]](mailto:[email protected])
+* Yunyu Lin  [[email protected]](mailto:[email protected])
+* reema93jain  [[email protected]](mailto:[email protected])
+* xinhuitian  [[email protected]](mailto:[email protected])
+* Alex Bocharov  [[email protected]](mailto:[email protected])
+* meastham [[email protected]](mailto:[email protected])
 
 To see the list of authors who created the source code of ClickHouse, published and distributed by ClickHouse, Inc. as the owner,
 run "SELECT * FROM system.contributors;" query on any ClickHouse server.

programs/local/LocalChdb.cpp

@@ -285,8 +285,12 @@ connection_wrapper::~connection_wrapper()
 
 void connection_wrapper::close()
 {
-    py::gil_scoped_release release;
-    close_conn(conn);
+    {
+        py::gil_scoped_release release;
+        close_conn(conn);
+    }
+    // Ensure that if a new connection is created before this object is destroyed that we don't try to close it.
+    conn = nullptr;
 }
 
 cursor_wrapper * connection_wrapper::cursor()