api!: return boolean value from dc_contact_is_verified()

Author: link2xt

deltachat-ffi/deltachat.h

@@ -5236,8 +5236,7 @@ int             dc_contact_is_blocked        (const dc_contact_t* contact);
  *
  * @memberof dc_contact_t
  * @param contact The contact object.
- * @return 0: contact is not verified.
- *    2: SELF and contact have verified their fingerprints in both directions.
+ * @return 1=contact is verified, 0=contact is not verified.
  */
 int             dc_contact_is_verified       (dc_contact_t* contact);
 

deltachat-ffi/src/lib.rs

@@ -4250,17 +4250,10 @@ pub unsafe extern "C" fn dc_contact_is_verified(contact: *mut dc_contact_t) -> l
     let ffi_contact = &*contact;
     let ctx = &*ffi_contact.context;
 
-    if block_on(ffi_contact.contact.is_verified(ctx))
+    block_on(ffi_contact.contact.is_verified(ctx))
         .context("is_verified failed")
         .log_err(ctx)
-        .unwrap_or_default()
-    {
-        // Return value is essentially a boolean,
-        // but we return 2 for true for backwards compatibility.
-        2
-    } else {
-        0
-    }
+        .unwrap_or_default() as libc::c_int
 }
 
 #[no_mangle]

python/src/deltachat/contact.py

@@ -73,7 +73,7 @@ def unblock(self):
 
     def is_verified(self) -> bool:
         """Return True if the contact is verified."""
-        return lib.dc_contact_is_verified(self._dc_contact) == 2
+        return bool(lib.dc_contact_is_verified(self._dc_contact))
 
     def get_verifier(self, contact) -> Optional["Contact"]:
         """Return the address of the contact that verified the contact."""