Skip to content

Commit e36abe2

Browse files
authored
✨ extend filtering to the cluster column (#56)
1 parent cfe71a4 commit e36abe2

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

  • openshift_cluster_login

openshift_cluster_login/ui.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ def default_sort(self) -> None:
106106
def on_mount(self) -> None:
107107
self.star_column = self.add_column(STAR)
108108
self.namespace_column = self.add_column("Namespace")
109-
self.add_column("Cluster")
109+
self.cluster_column = self.add_column("Cluster")
110110
for ns in self.namespaces:
111111
self.add_row(
112112
STAR if ns.starred else NOT_STAR,
@@ -119,12 +119,16 @@ async def watch_namespace_filter(self) -> None:
119119
"""Watch for changes to the namespace filter."""
120120
all_data = self._data | self._hidden_data
121121

122+
def get_searchable_text(row_key):
123+
row_data = all_data[row_key]
124+
return f"{row_data[self.namespace_column]} {row_data[self.cluster_column]}"
125+
122126
row_keys_to_display = (
123127
set(
124128
fuzzyfinder(
125129
self.namespace_filter,
126130
all_data.keys(),
127-
accessor=lambda row_key: all_data[row_key][self.namespace_column],
131+
accessor=get_searchable_text,
128132
sort_results=False,
129133
)
130134
)

0 commit comments

Comments
 (0)