Fix artifact filenames (#67)

Author: cknitt

.github/workflows/ci.yml

@@ -61,21 +61,25 @@ jobs:
       - name: Test
         run: esy test
 
-      - name: Get binary path
-        id: print_binary_path
+      - name: (release only) Get artifact filenames
+        id: get_filenames
+        # if: github.event_name != 'pull_request'
+        run: node .github/workflows/get_filenames.js
+
+      - name: (release only) Get exe
+        # if: github.event_name != 'pull_request'
         shell: bash
         run: |
           # from https://stackoverflow.com/a/24848739/617787
           s=$(pwd); d=$(dirname $(esy x which Extract.exe));
           while [ "${d#$s/}" == "${d}" ]
-          do s=$(dirname $s);b="../${b}"; done; 
+          do s=$(dirname $s);b="../${b}"; done;          
           ESY__BINARY_PATH=${b}${d#$s/}/Extract.exe
-          echo "ESY__BINARY_PATH: $ESY__BINARY_PATH"
-          echo "##[set-output name=path;]$ESY__BINARY_PATH"
+          mv "$ESY__BINARY_PATH" ${{ steps.get_filenames.outputs.exe_name }}
 
-      - name: (only on release) Upload artifacts ${{ matrix.os }}
-        if: github.event_name != 'pull_request'
+      - name: (release only) Upload artifact ${{ matrix.os }}
+        # if: github.event_name != 'pull_request'
         uses: actions/upload-artifact@v2
         with:
-          name: ${{ matrix.os }}
-          path: ${{ steps.print_binary_path.outputs.path }}
+          name: ${{ steps.get_filenames.outputs.artifact_name }}
+          path: ${{ steps.get_filenames.outputs.exe_name }}

.github/workflows/get_filenames.js

@@ -0,0 +1,39 @@
+const fs = require("fs");
+const os = require("os");
+
+const packageJson = fs.readFileSync("package.json");
+const { version } = JSON.parse(packageJson);
+
+const exeName = getExeName();
+const platform = getPlatformName();
+const artifactName = `bs-react-intl-extractor-${version}-${platform}`;
+
+// For passing output to subsequent GitHub actions
+console.log(`::set-output name=exe_name::${exeName}`);
+console.log(`::set-output name=artifact_name::${artifactName}`);
+
+function getPlatformName() {
+  const platform = os.platform();
+
+  switch (platform) {
+    case "linux":
+      return "linux";
+    case "darwin":
+      return "macos";
+    case "win32":
+      return "windows";
+    default:
+      throw new Error(`Unexepected platform ${platform}`);
+  }
+}
+
+function getExeName() {
+  const platform = os.platform();
+
+  switch (platform) {
+    case "win32":
+      return "bs-react-intl-extractor.exe";
+    default:
+      return "bs-react-intl-extractor";
+  }
+}

package.json

@@ -15,8 +15,7 @@
   "scripts": {
     "test": "esy x RunTests.exe",
     "format": "scripts/format.sh",
-    "setVersion": "node scripts/setVersion.js",
-    "zip": "esy build && node scripts/createZip.js"
+    "setVersion": "node scripts/setVersion.js"
   },
   "dependencies": {
     "@esy-ocaml/reason": "^3.6.0",