[file-picker] - mime types filter is ignored when limit is set to 0

[ThomasVanleynseele]

Hi all,

I'm looking for some clarification and guidance.

Based on my testing and your documentation 🔝 it seems that setting limit to 0 basically disables types for android, iOS seems to work fine?

Now I have a requirement to upload multiple files of a specific mime type. Currently this library does not support that?

1. Is my assumption correct that this library does not support my use case for Android?
2. This seems like a pretty essential feature, are you planning to support this or not?
3. How would you tackle my use case? Should I look for an alternative library?

Thanks for taking the time, looking forward to your response.

[robingenz]

Hi, short answer: this is not supported by Android. Feel free to submit a PR if you find a way to solve this. I would love to merge it.

[robingenz]

Unfortunately, we forgot to put a comment with a link to the Android documentation in the code. I would need to search for it myself. If you think it's possible, feel free to create a PR. If you find the reason, why it's not possible, you can still submit a PR with a comment. That would be great!

[ThomasVanleynseele]

Thanks, I'll patch it on our side first, seems to work fine here on my Android Pixel. I'll run it through our QA team, get some more validation and then submit a PR if all is good 👍

[nils-ms]

Hi @ThomasVanleynseele, I am currently facing the same issue.
Were you able to submit a PR?
And if not, how did you patch the issue on your side?

[ThomasVanleynseele]

Hi @nils-ms , I patched it on our side like this:

source file:

capacitor-plugins/packages/file-picker/android/src/main/java/io/capawesome/capacitorjs/plugins/filepicker/FilePickerPlugin.java

Line 102 in 0ffd5ef

if (limit == 1 && parsedTypes != null && parsedTypes.length > 0) {

replace

 if (limit == 1 && parsedTypes != null && parsedTypes.length > 0) {
       intent.putExtra(Intent.EXTRA_MIME_TYPES, parsedTypes);
}

with

if (parsedTypes != null && parsedTypes.length > 0) {
       intent.putExtra(Intent.EXTRA_MIME_TYPES, parsedTypes);
}

It's been working for us, but use at your own risk or submit a PR if you want this to be merged.

[nils-ms]

Thank you for your response!
I will check what will work best for my case.