Skip to content

Commit 1735524

Browse files
committed
Fix Rector compliance and JSON assertion ordering
1 parent 3d2998b commit 1735524

2 files changed

Lines changed: 7 additions & 2 deletions

File tree

‎src/Service/PackagistImporter.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ private function getDataForPackage(string $packageName): array
178178
$latestStable = end($stableVersions);
179179
$keywordRelease = $latestStable ?: null;
180180
if ($keywordRelease === null && $development !== []) {
181-
$installVersion = $development[array_key_first($development)]['version'];
181+
$installVersion = array_first($development)['version'];
182182
foreach ($versions as $version) {
183183
if ($version->getVersion() === $installVersion) {
184184
$keywordRelease = $version;

‎tests/TestCase/Island/DevelopmentCompatibilityTest.php‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,12 @@ public function testDevelopmentSelectionAndStableDefaults(): void
3434
]);
3535
$packages->saveOrFail($package);
3636
Cache::clear('catalogue');
37-
$this->assertSame($development, $packages->get($package->id)->development_compatibility);
37+
$storedDevelopment = $packages->get($package->id)->development_compatibility;
38+
$this->assertNotNull($storedDevelopment);
39+
// MySQL may reorder JSON object keys; values and types must survive unchanged.
40+
ksort($development[6]);
41+
ksort($storedDevelopment[6]);
42+
$this->assertSame($development, $storedDevelopment);
3843
$this->assertSame(26, $packages->find('catalogue', filters: [])->count());
3944
$this->assertSame(['major' => '5', 'plugins' => 25], $packages->ecosystemStats()['current_support']);
4045
$this->assertSame(26, $packages->ecosystemStats()['plugins']);

0 commit comments

Comments
 (0)